The submitted from address (=?UTF-8.....) is not valid

Please move this to the correct queue if I selected the wrong SMTP module. Webform is only using the PHP function for encoding the FROM address as specified by e-mail standards. SMTP module should decode the headers if it's doing additional validation on the way out.

In the webforms config "Email format settings" I switched Long format: "Example Name" to the Short format: name@example.com and now everything works fine. Seams that the SMTP module is not capable with the from address set to format: "Example Name" and encoded

That helped me a lot.

Thank you

filnug

#2 it is work with me too thank you :)

i have another question i am using drupal as another language for my website

now
E-mail template

Submitted on %date

Submitted by user: %username

Submitted values are:

%email_values

The results of this submission may be viewed at:

%submission_url

Include all files as attachments

when the website send the email it send like

PGh0bWw+CiAgPGhlYWQ+CiAgICA8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRl bnQ9InRleHQvaHRtbDsgY2hhcnNldD11dGYtOCIgLz4KICAgICAgICA8c3R5bGUgdHlwZT0idGV4

this is what is send to me

small text change

Same issue on 7.x-1.0 version when E-mail settings in Webform module set to 'Long format'.

I've found another workaround for this bug: E-mail format can be set to Long if 'Send e-mail as HTML' is also checked. But for this checkbox to appear the mimemail module should be enabled. Tested on D6 only.

This issue is caused by improper email validation on the From address when the From name contains new line characters in between the double quotes.

Per Section 3.1.1 of RFC 822, long header fields are permitted to contain new line breaks. Situations where this may occur are with modules such as Webform which runs the From header through mime_header_encode(). If the string is longer than 47 bytes it will be chunked apart with new line characters.

The problematic code from SMTP Authentication is in smtp.mail.inc starting at line ~105:

if (preg_match('/^"?.*"?\s*<.*>$/', $from)) {
      // . == Matches any single character except line break characters \r and \n.
      // * == Repeats the previous item zero or more times.
      $from_name = preg_replace('/"?([^("\t\n)]*)"?.*$/', '$1', $from); // It gives: Name
      $from      = preg_replace("/(.*)\<(.*)\>/i", '$2', $from); // It gives: name@domain.tld
}
elseif (!valid_email_address($from)) {
       drupal_set_message(t('The submitted from address (@from) is not valid.', array('@from' => $from)), 'error');
       if ($logging) {
         watchdog('smtp', 'The submitted from address (@from) is not valid.', array('@from' => $from), WATCHDOG_ERROR);
       }
       return FALSE;
     }

The first regex here is does not match new line characters in between the double quotes causing those specific From values with them to fail. Once that fails, it moves over to valid_email_address to attempt to validate where it will again fail as this function uses PHP's FILTER_VALIDATE_EMAIL filter which does not support whitespace folding.

I've created a patch to fix this problem as well as also reduce the number of regexes being used to match and pull out the name and email from this header value as there is no need to run the regex 3 times:

     if (preg_match('/^"?([^"]*)"?\s*<(.*)>$/', $from, $matches)) {
       // First parenthesis contains the quoted sender's name
       $from_name = $matches[1];
       // Second parenthesis contains the sender's email address
       $from = $matches[2];
     } 
     elseif ...

I'm not sure about code quality, but patch worked great for me.

There really should be a comment before the if() statement explaining what it's doing.

Rerolling the patch.

Putting this back to needs work as there really ought to be some tests around the string handling.

+1 on the reroll. Manual tested it and I can confirm this is working in my case. Thank you for this.

Patches are not compatible with the current 7-1.x branch or 7-1.x-dev branch for me.

I have got the same problem when i mixed mimemail interface with smtp and i have got empty "Email from" settings in smtp. When i fill form "smtp settings" and save the errors goes away. For the problems with webform, i think that change email type in global webform settings should help.

Since the code in the previous patches was moved I tried to locate them and apply the changed regex there, this patch seems to do the trick for me.

#15 worked for me. It was patched onto 7.x-1.7.

With #15 patch line breaks in email address and tabulations in name marked as valid.
But it wrong. In name allowed line breaks (@see https://www.ietf.org/rfc/rfc2047.txt)

An 'encoded-word' may not be more than 75 characters long, including
'charset', 'encoding', 'encoded-text', and delimiters. If it is
desirable to encode more text than will fit in an 'encoded-word' of
75 characters, multiple 'encoded-word's (separated by CRLF SPACE) may
be used.

FWIW: Here's a functional test for the encoded name scenario.

The short encoded name test passes also with the current code, but I added it for completeness.

The patch by armrus needs re-rolling (offset 38 lines), but the change is identical to #17.

So here's the combined patch and test. Ready for review.