Localized strings break popup window layout/size

Did you forget the screenshot?

I had exactly the same problem - apparently the current theming of that part doesn't play nice with localizations and other texts involved (if long).

I Just adjusted style.css in my theme, and made the texts as short as possible by editing localizations and category-names (shown then in selector). The default styling divides space between main part and cancel button in percents, which is wasting space.

My add-on inside style.css:

div#header-browse, div#header-uploading, div#header-properties { float: left; width: auto; }
div#header-browse div, div#header-uploading div, div#header-properties div { display: inline; }
div#header-startover, div#header-cancel { float: right; width: auto; }

This ensure maximum space for the main part (and in worst case the cancel button will go down, not the useful ones).

My screenshot attached (BTW, I'm also in Prague :-)

Just an idea - would it be acceptable to increase the size of pop-up window? It would make the situation with long strings better a bit, and also reduce the need for scrolling (or window re-sizing), which is very frequent in most workflow-steps, on my site at least.

If extending the size of the popup window would fix this issue, I would accept a patch that increases its size to the minimum size needed.

Problem is, that such a "minimum size needed" is almost impossible to find. It depends on localization, as well as custom settings (number of thumbnails per page). My personal preference would be "maximum size acceptable" instead, which might be something like a common "smaller" screen size (say, 1024x768), MINUS reasonable border (say, 10% each side). After all, the popup is supposed to be dealt with first, before returning to the base page, so it doesn't matter if we hide a little more of the background.

My personal experience is, that number of thumbnails per page needs to be around 20, or more, otherwise browsing large image-vocabularies is a pain (pager shows only few pages around the current one, and no address-bar to edit). And to make such a page usable (without extensive scrolling), as well as the image-node submitting form itself, and even the image-inserting properties - well, the first thing I do with the popup each time is to resize it to almost twice the original size... Always...

I'm not sure, how others think about this, though.

Jiří, please don't take my words exactly in this case. You're speaking of doubling the size of IA's popup window. The only limitation I could think of and I would like to adhere with is a compatibility with 800x600 screen resolutions. Thus, even a window size of 750 x 400 should be in line with such a screen resolution. IMHO, at least that should suit any possible translations out there.

The reason behind this limitation is a hidden goal of mine to implement the popup window as a modal dialog Sometime Near In The Future™ (see Inline API for more information).

What about making the window size customizable on the settings page, and using Drupal.settings to pass them on to editor_plugin.js? Right now the window size appears to be hardcoded (in editor_plugin.js).

Or, if you don't want to clutter the img_assist settings page too much, then at least using Drupal.settings will give people a chance to override the defaults with their own code.

What do you think?

PS. I working with 6.2 but it appears this works the same as 5.x if I'm not mistaken.

For now, it would be sufficient if the window size would just be increased.

2.x is completely rewritten currently, so we should not put too much effort into this issue.

subscribing

I've just tested 6.x-3.x-dev and the problem persists.