Upgrade path tests for all system module variables converted to CMI so far [#1789606]

Whilst working on #1464554: Upgrade path for image style configuration I discovered that I created a patch with a critical defect #1669902: Adjust system.performance configuration for new guidelines due to the following code:

function system_update_8017() {
  update_variables_to_config('system.site', array(
    'cache' => 'cache.page.enabled', 
    'page_cache_maximum_age' => 'cache.page.max_age', 
    'page_compression' => 'response.gzip', 
    'preprocess_css' => 'preprocess.css', 
    'preprocess_js' => 'preprocess.js',
  ));
}

We should be updating these variables to the system.performance config object!!!!

This patch fixes this and includes upgrade path tests for all the system module variables migrated to CMI so far. The patch extends on the excellent work done by @sun in #1464554: Upgrade path for image style configuration.

Comment	File	Size	Author
#2	system-config-upgrade-path-1-just-test.patch	5.74 KB	andypost
#2
#1	system-config-upgrade-path-1-just-test.patch	0 bytes	andypost
#1
	system-config-upgrade-path.patch	6.29 KB	alexpott

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

andypost

he/him

Russian

CreditAttribution: andypost commented 20 September 2012 at 19:56

File	Size
system-config-upgrade-path-1-just-test.patch	0 bytes

Let's make sure that test detects a problem

Comment #2

andypost

he/him

Russian

CreditAttribution: andypost commented 20 September 2012 at 19:58

File	Size
system-config-upgrade-path-1-just-test.patch	5.74 KB

And again

Comment #3

20 September 2012 at 20:23

Status:

Needs review

» Needs work

The last submitted patch, system-config-upgrade-path-1-just-test.patch, failed testing.

Comment #4

andypost

he/him

Russian

CreditAttribution: andypost commented 20 September 2012 at 20:30

Status:

Needs work

» Reviewed & tested by the community

Awesome patch and it looks like now we have a universal upgrade tests for variables!

+++ b/core/modules/system/system.installundefined
@@ -1920,7 +1920,7 @@ function system_update_8016() {
-  update_variables_to_config('system.site', array(
+  update_variables_to_config('system.performance', array(

Actual fix and a bunch of tests that could be extended.