In login_redirect.module starting on line 39: 

      $variables['items'] = array(
        l(t('Enable the module'), 'admin/modules'),
        l(t('Configure the module'), 'admin/login_redirect/settings'),
        l(t('Enable the module'), 'admin/modules'),
        l(t('Configure the module'), 'admin/login_redirect/settings'),

should be:

    $variables['items'] = array(
        l(t('Enable the module'), 'admin/modules'),
        l(t('Configure the module'), 'admin/config/system/login_redirect'),
CommentFileSizeAuthor
#5 login_redirect-fix_admin_settings-1788404-5.patch903 bytesforestmars
#4 login_redirect-fix_admin_settings-1788404-4.patch891 bytesforestmars
#2 login_redirect-fix_admin_settings-1788404-2.patch891 bytesforestmars
#1 login_redirect-fix_admin_settings-1788404-2.patch891 bytesforestmars

Comments

forestmars’s picture

forestmars commented
StatusFileSize
new login_redirect-fix_admin_settings-1788404-2.patch891 bytes

patch.

forestmars’s picture

forestmars commented
Status: Active » Patch (to be ported)
StatusFileSize
new login_redirect-fix_admin_settings-1788404-2.patch891 bytes
forestmars’s picture

forestmars commented
Status: Patch (to be ported) » Needs review

(Setting to needs review.)

forestmars’s picture

forestmars commented
StatusFileSize
new login_redirect-fix_admin_settings-1788404-4.patch891 bytes
forestmars’s picture

forestmars commented
StatusFileSize
new login_redirect-fix_admin_settings-1788404-5.patch903 bytes

test bot?

Jeffrey C.’s picture

Jeffrey C. commented

Thank you. Will review it as soon as possible then fix it.

Jeffrey C.’s picture

Jeffrey C. commented

Hello,

For some reason the testbot is not working. Can you please make sure your patch works so later this month when I have time to look into this the time will be minimized? Thanks.

Status: Needs review » Needs work

The last submitted patch, login_redirect-fix_admin_settings-1788404-5.patch, failed testing.

forestmars’s picture

forestmars commented

Ah, testbot is back. I'll reroll.

Jeffrey C.’s picture

Jeffrey C. commented

Thanks. I'll make sure this bug gets fixed by this weekend.

Jeffrey C.’s picture

Jeffrey C. commented
Title: settings page link broken » Settings Page Links Broken
Status: Needs work » Fixed

Fixed in the latest commit: 6ba48b7. Will make it a release. Thanks again for contributing!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 6ba48b7 on 7.x-1.x, 8.x-1.x by Jeffrey C.: 
    Fixed the settings page broken problem [#1788404]