Tedbow,

Per our conversations, I am in the process of changing the labels and the field descriptions on the Add / Edit Entityform page to be consistent with the labels and field descriptions on the Add / Edit Content Type pages. I will be making the following changes:

  1. Change the label on "Label" to "Name".
  2. Change the description for "Label" / "Name" to "The human-readable name of this Entity Form type. This text will be displayed as part of the list in the Add entityform type page. It is recommended that this name begin with a capital letter and contain only letters, numbers, and spaces. This name must be unqiue."
  3. Change the label on "Intro Form Instructions" to "Description"
  4. Change the description for "Intro Form Instructions" / "Description" to "Describe the entityform. The text will be displayed on the Add entityform type page."
  5. Change the description for "Draft save text" to "This text will be displayed to the user when the form is saved as a draft." Note: this corrects the misspelling of "dispaly".

I'm in the process of writing user documentation for this screen. If I find any other labels or descriptions that need to be changed / corrected I will note them in subquent comments.

Once I've finished making and tested all of my changes, I will submit one patch with all of the corrections.

Dennis

CommentFileSizeAuthor
#10 entityform-Update_description_on_Entityform_edit_page_1786304-7.patch3.8 KBtedbow
#8 Update_description_on_Entityform_edit_page_1786304-7.patch3.91 KBdensolis
#4 Update_description_on_Entityform_edit_page_1786304-4.patch3.91 KBdensolis
#2 Update_description_on_Entityform_edit_page_1786304-2.patch3.92 KBdensolis

Comments

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

Dennis,
Instead of

The text will be displayed on the Add entityform type page."

It should be

The text will be displayed on the Entityform submission page."

Also I am not sure if we need:

It is recommended that this name begin with a capital letter and contain only letters, numbers, and spaces.

Drupal will filter characters out for the machine-name so you can put other characters in.

Thanks

densolis’s picture

densolis commented
Issue tags: ++patch
StatusFileSize
new Update_description_on_Entityform_edit_page_1786304-2.patch3.92 KB

All,

Here is a patch that contains the following documentation patches to entityform:

  1. The label called "Label" was renamed to "Name". This is in keeping with the field name on the Add Content Type - Basic Page.
  2. The description for this field was changed to "The human-readable name of this Entity Form type. This text will be displayed as part of the list in the Add entityform type page. This name must be unqiue."
  3. The description for "Redirect Path" was changed from "What path should the.." to "What relative path should the..."
  4. The description text for Draft save text was changed to "This text will be displayed to the user when the form is saved as a draft." Note: this corrects the misspelling of "dispaly".
  5. Changed the description text for Submission Reply from "Text for correct submission" to "This text will be displayed to the user when a correct form is submitted."
  6. I change the descriptionfield for Form status from "Can users submit this form?" to ""Can users submit this form? Open means the users can submit this form. Closed means the user can not submit the form.
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Needs work

@densolis
Can you change this:

t('These user instructions will appear at the top of every page within this entity form.'),

to:

t('These user instructions will appear at the top of every page within this form.'),

This keeps it the same as other places we just use "form"

densolis’s picture

densolis commented
StatusFileSize
new Update_description_on_Entityform_edit_page_1786304-4.patch3.91 KB

Tedbow,

Per your request, I changed

"These user instructions will appear at the top of every page within this entity form."

on Intro Form instructions on the main entity form form to

"These user instructions will appear at the top of every page within this form."

Given the above, I also change the description text on Name from

"The human-readable name of this Entity Form type"

to

"The human-readable name of this entityform."

Dennis

Here is the revised patch.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

Sorry could you change to:
"The human-readable name of this EntityForm type"

densolis’s picture

densolis commented

Tedbow,

Now that I re-read the sentence - ""The human-readable name of this Entity Form type.", I wonder if that is more accurate than ""The human-readable name of this Entity Form."

Dennis

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

No technically it is for the "EntityForm Type"

densolis’s picture

densolis commented
StatusFileSize
new Update_description_on_Entityform_edit_page_1786304-7.patch3.91 KB

Tedbow,

To save time, here is the same patch as above, but were I only changed

"These user instructions will appear at the top of every page within this entity form."

on Intro Form instructions on the main entity form form to

"These user instructions will appear at the top of every page within this form."

The second line (from above) is per the original, however I changed Entity Type to entity type (lowercase).

You can take your pick.

Dennis

densolis’s picture

densolis commented

Tedbow,

Do you want me to change it back to uppercase - Entity Form vs entity form?

Dennis

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review
StatusFileSize
new entityform-Update_description_on_Entityform_edit_page_1786304-7.patch3.8 KB

Ok I re-rolled this and change a couple things.

I kept "Label". Let me know if you see any other problems

densolis’s picture

densolis commented

tedbow,

I applied the patch and everything looks good.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Fixed

Committed to 7.x-1.x

thanks @densolis

densolis’s picture

densolis commented

tedbow,

I changed the status to closed - fixed so it would drop off the open issues report.

Dennis

densolis’s picture

densolis commented
Status: Fixed » Closed (fixed)

tedbow,

I get the comment right on the previous post, but I did not change the status. This time I changed the status.

Dennis

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

Thanks