In Drupal 7, the user information was not being passed to Olark through javascript like it should. I have modified the olark.js file to be compliant with Drupal 7 standards and it now works fine.

CommentFileSizeAuthor
#7 javascript_not_passing-1785322-7.patch2.04 KBjoelpittet
#5 olark-js-to-d7-update-1785322-5.patch2.22 KBjsagotsky
#4 olark-js-to-d7-update-1785322-4.patch2.18 KBundrgrnd
#3 olark-js-to-d7-update-1785322-3.patch2.27 KBundrgrnd
#1 olark-javascript-vars-1785322-1.patch2.4 KBledzepp94

Comments

ledzepp94’s picture

ledzepp94 commented
StatusFileSize
new olark-javascript-vars-1785322-1.patch2.4 KB

Attached is the patch.

kalman.hosszu’s picture

kalman.hosszu commented
Status: Needs review » Needs work

You should correct the code based on coding standards.

undrgrnd’s picture

undrgrnd commented
StatusFileSize
new olark-js-to-d7-update-1785322-3.patch2.27 KB

Using the above patch, made a small JS update to better track the users email and name as it wasn't properly working.

undrgrnd’s picture

undrgrnd commented
StatusFileSize
new olark-js-to-d7-update-1785322-4.patch2.18 KB

Sorry, file I attached had incorrect directory structure, I cleaned it up.

jsagotsky’s picture

jsagotsky commented
StatusFileSize
new olark-js-to-d7-update-1785322-5.patch2.22 KB

Rerolled to include http://drupal.org/node/1433260

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue summary: View changes

Here's a review:

  1. +++ b/olark.js
@@ -1,27 +1,34 @@
-}
+(function ($) {
...
+})(jQuery);

    Why the need for jQuery? 

  2. +++ b/olark.js
@@ -1,27 +1,34 @@
+            //$('#habla_pre_chat_name_input').val(Drupal.settings.olark.name);
+            //$('#habla_pre_chat_email_input').val(Drupal.settings.olark.mail);

    I've removed this upstream no need to keep commented code out.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 7.x-1.0-beta1 » 7.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new javascript_not_passing-1785322-7.patch2.04 KB

How's this for clean-up?

attach has a settings argument too:)

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Sorry for the 2 year delay into looking at this. Promise if someone reviews this it will get committed this week. If not I'll likely commit it anyways:P

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Assigned: ledzepp94 » Unassigned
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Committed to -dev.

  • joelpittet committed 171926a on 7.x-1.x authored by undrgrnd 
    Issue #1785322 by undrgrnd, joelpittet, ledzepp94, jsagotsky: Javascript...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.