Found out while trying to get #1742734: [META] Widgets as Plugins come out green.

The database dump provided in drupal-7.filled.standard_all.database.php.gz contains definitions of field instances with invalid widget properties :

<?php
'widget' => array(
 
'type' => 'select',
 
'module' => NULL,
);
?>

The 'select' widget type doesn't exist (and didn't exist in D7) - hence the NULL 'module' entry.
The correct widget is 'options_select', module 'options'.

Attached patch fixes this.
This is a binary patch, since we ship gzipped files - attached a diff of the unzipped txt files as well.

Files: 
CommentFileSizeAuthor
#11 drupal-7.filled.standard_all.database-1778986-11-D7.patch225.65 KByched
PASSED: [[SimpleTest]]: [MySQL] 39,397 pass(es).
[ View ]
#1 drupal-7.filled.standard_all.database-1778986-1.patch220.53 KByched
PASSED: [[SimpleTest]]: [MySQL] 41,256 pass(es).
[ View ]
diff.txt114.37 KByched
drupal-7.filled.standard_all.database.patch220.08 KByched
FAILED: [[SimpleTest]]: [MySQL] 41,241 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

yched’s picture

StatusFileSize
new220.53 KB
PASSED: [[SimpleTest]]: [MySQL] 41,256 pass(es).
[ View ]

I just figured out that we shipped with the script that generates the dump.
Attached patch fixes the script too.

Status:Needs review» Needs work

The last submitted patch, drupal-7.filled.standard_all.database-1778986-1.patch, failed testing.

yched’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, drupal-7.filled.standard_all.database-1778986-1.patch, failed testing.

yched’s picture

Status:Needs work» Needs review
xjm’s picture

xjm’s picture

Status:Needs review» Reviewed & tested by the community

Clear bugfix. Can we check whether the 7.0 -> 7.x tests have a similar bug? If so this will need a backport(ish).

yched’s picture

Status:Reviewed & tested by the community» Needs review
Issue tags:+needs backport to D7

As pointed by @xjm, D7's generate-d7-content.sh has the same issue.
Adding "Needs backport" tag

yched’s picture

Status:Needs review» Reviewed & tested by the community

crosspost

webchick’s picture

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

Dear sweet crap on a cracker. What a large patch for such a small bug. :)

Committed and pushed to 8.x. Moving to 7.x for backport.

yched’s picture

Status:Patch (to be ported)» Needs review
StatusFileSize
new225.65 KB
PASSED: [[SimpleTest]]: [MySQL] 39,397 pass(es).
[ View ]

Patch for D7.

xjm’s picture

Status:Needs review» Reviewed & tested by the community

Yay.

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Awesome, thanks a lot for this fix.

Committed and pushed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.