Found out while trying to get #1742734: [META] Widgets as Plugins come out green.
The database dump provided in drupal-7.filled.standard_all.database.php.gz contains definitions of field instances with invalid widget properties :
'widget' => array(
'type' => 'select',
'module' => NULL,
);
The 'select' widget type doesn't exist (and didn't exist in D7) - hence the NULL 'module' entry.
The correct widget is 'options_select', module 'options'.
Attached patch fixes this.
This is a binary patch, since we ship gzipped files - attached a diff of the unzipped txt files as well.
Comment | File | Size | Author |
---|---|---|---|
#11 | drupal-7.filled.standard_all.database-1778986-11-D7.patch | 225.65 KB | yched |
#1 | drupal-7.filled.standard_all.database-1778986-1.patch | 220.53 KB | yched |
diff.txt | 114.37 KB | yched | |
drupal-7.filled.standard_all.database.patch | 220.08 KB | yched | |
Comments
Comment #1
yched CreditAttribution: yched commentedI just figured out that we shipped with the script that generates the dump.
Attached patch fixes the script too.
Comment #3
yched CreditAttribution: yched commented#1: drupal-7.filled.standard_all.database-1778986-1.patch queued for re-testing.
Comment #5
yched CreditAttribution: yched commented#1: drupal-7.filled.standard_all.database-1778986-1.patch queued for re-testing.
Comment #6
xjm@yched mentioned that the earlier random fails were due to #1779638: Unexplained test failure in LocaleFileImportStatus->testBulkImportUpdateExisting().
Comment #7
xjmClear bugfix. Can we check whether the 7.0 -> 7.x tests have a similar bug? If so this will need a backport(ish).
Comment #8
yched CreditAttribution: yched commentedAs pointed by @xjm, D7's generate-d7-content.sh has the same issue.
Adding "Needs backport" tag
Comment #9
yched CreditAttribution: yched commentedcrosspost
Comment #10
webchickDear sweet crap on a cracker. What a large patch for such a small bug. :)
Committed and pushed to 8.x. Moving to 7.x for backport.
Comment #11
yched CreditAttribution: yched commentedPatch for D7.
Comment #12
xjmYay.
Comment #13
webchickAwesome, thanks a lot for this fix.
Committed and pushed to 7.x.