The first t() in flag_update_page() is missing one of its replacement tokens.

    drupal_set_message(t('The flag %name is already up-to-date with the latest Flag API and does not need upgrading.'));
CommentFileSizeAuthor
#8 1777498-missingname-flag-7.patch1.46 KBACF
#5 1777498-missingname-flag-5.patch1.46 KBACF
#1 1777498-missing%name-flag-1.patch1.46 KBACF

Comments

ACF’s picture

ACF commented
StatusFileSize
new 1777498-missing%name-flag-1.patch1.46 KB

Pushed fix for this and 1777500 together.

ACF’s picture

ACF commented
Status: Active » Needs review
joachim’s picture

joachim commented

Thanks!

Though the server seems not to like the % in the filename. Can you try uploading it again with a different name?

Status: Needs review » Needs work

The last submitted patch, 1777498-missing%name-flag-1.patch, failed testing.

ACF’s picture

ACF commented
Status: Needs work » Needs review
StatusFileSize
new 1777498-missingname-flag-5.patch1.46 KB

Try again.

joachim’s picture

joachim commented
Status: Needs review » Fixed

Issue #1777498 by ACF: Fixed missing placeholder in message on flag update page."

Committed half of that patch here; the other half at #1777500: typo in confirmation message.

Thanks for working on this!

joachim’s picture

joachim commented
Version: 7.x-3.x-dev » 6.x-2.x-dev
Status: Fixed » Patch (to be ported)

This cherry-picked to 7-2 but not to 6-2.

ACF’s picture

ACF commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1777498-missingname-flag-7.patch1.46 KB

Ported to d6

joachim’s picture

joachim commented
Status: Needs review » Fixed

Committed, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.