Allow toggling of roles (6.x backport)

I won't complain about multiple roles. I am looking at the module to figure things out. Not sure it supports two parameters (uid, rid) out of the box.

a single role would probably be easier to do.

Moving this to D7 as it looks d.o will soonish convert to that.

Hi Nigel,

thank you for working on this!

Unfortunately, I totally missed the commit and instead fixed all role assignments manually. I could kick myself!

I've tried the D6 version and in addition to what Greg said, I've found a few bugs. Uploading your patch so I can dredit it.

+++ b/fasttoggle.admin.inc
@@ -92,6 +94,15 @@ function fasttoggle_settings_form() {
+          'status' => t('Status <small>(unblocked/blocked)</small>'),

The role options are missing

+++ b/fasttoggle.admin.inc
@@ -92,6 +94,15 @@ function fasttoggle_settings_form() {
+      '#default_value' => array_keys(array_filter(variable_get('fasttoggle_user_settings', array('status' => TRUE)))),

I guess this is a typo in the variable name, needs to be _role_ not _user_

+++ b/fasttoggle.module
@@ -69,8 +71,13 @@ function fasttoggle_menu() {
+  $available_roles = fasttoggle_potential_toggleable_roles();

Shouldn't this take the admin setting into account?

+++ b/fasttoggle.module
@@ -69,8 +71,13 @@ function fasttoggle_menu() {
+    $roles[] = 'toggle role \'' . $available_roles[$key] . '\'';

Here you use "toggle role 'foo'"

+++ b/fasttoggle.module
@@ -181,6 +207,29 @@ function fasttoggle_get_options($type) {
+  if (isset($user->roles[$role]))
+    unset($result['roles'][$role]);
+  else
+    $result['roles'][$role] = TRUE;

Coding style! ;)

+++ b/fasttoggle.module
@@ -195,32 +244,48 @@ function fasttoggle_fasttoggle_options($type, $obj = NULL) {
+        if (user_access('fasttoggle role ' . $rolename)) {

Here you use "fasttoggle role foo" for the permission. obviously you need to standardize.

+++ b/fasttoggle.module
@@ -318,6 +400,7 @@ function fasttoggle_fasttoggle_labels($style) {
+        'role' => array(0 => t('add role '), 1 => t('revoke role ')),

I think this need to be reversed, it is not working exactly opposite: "add role" takes is away and "revoke" adds it.

Nigel, thanks for your help! THis is now live on d.o and will make maintenance lot easier.