Closed (fixed)
Project:
Views (for Drupal 7)
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 Sep 2012 at 21:14 UTC
Updated:
4 Jan 2014 at 02:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
chrisjlee commentedDid the first and easiest one by hand. attached is the patch of views.settings.yaml
Comment #2
chrisjlee commentedReattached a new patch was able to use `sed` to retab all the files. including the one i did by hand in #2
For those curious it can be done this way:
sed -e 's/^/~/' -e ': r' -e 's/^\( *\)~ /\1 ~/' -e 't r' -e 's/~//' file-name.yamlComment #4
chrisjlee commentedComment #5
chrisjlee commentedComment #7
chrisjlee commentedComment #8
damiankloip commentedThe tests pass and the patch looks clean :) so this would definitely be an RTBC patch. However, yesterday we converted all the views in tests to yaml/config too yesterday (sorry!). All of these are in the config directory of views_test_config module. Seems like you would be a good candidate to convert the rest to...
Comment #9
chrisjlee commentedwhoops well try again!
Comment #11
tim.plunkettSince you need to reroll, you should pull again because there was another yml file added in #1765824: Provide a way to map views fields to a certain meaning
Comment #12
chrisjlee commentedComment #13
aspilicious commentedLets commit this
Comment #14
dawehnerI just looked at the changes and you seem to have missed the files in views_test_data, do you want to change them as well?
Comment #15
chrisjlee commented@dawehner Yeah sure no problem. i'll get it done during lunch time. Sorry i missed it.
Comment #16
chrisjlee commentednevermind there are only a few files. so i'll try again with testbot...
Comment #18
chrisjlee commentedLet me know if i missed any other files!
Comment #19
tim.plunkettLast bit, there are 8 files in the top level config directory:
Comment #20
chrisjlee commented@tim i was told those were already completed... see #8.
I could try to reroll that patch (see #7 i converted all those files there as well when i didn't need to :) ) if you'd like too.
Comment #21
tim.plunkettI think you misunderstood, sorry.
There are 3 directories with YAML in them:
Your patch in #18 does the second two fine, but is missing the first one.
Comment #22
aspilicious commentedComment #24
tim.plunkettTrying this.
Comment #25
tim.plunkettCommitted!
http://drupalcode.org/project/views.git/commit/d4844a8
Thanks so much @chrisjlee, sorry for all of the confusion. Congratulations on your first Views commit!
Comment #26
chrisjlee commented@tim.plunkett Awesome thanks! Hopefully many more.