Following #1768484: Indentation in YAML files violates Drupal coding standards, we need to update our YAML file indentations to 2 spaces.

heyrocker suggests using the yaml dumper rather than doing it by hand. :)

Files: 
CommentFileSizeAuthor
#24 views-1774290-24.patch141.32 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 1,708 pass(es).
[ View ]
#22 yaml-2spaces.patch141.32 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] 0 pass(es), 63 fail(s), and 0 exception(s).
[ View ]
#18 1774290-views-yamlindent-4.patch97.05 KBchrisjlee
PASSED: [[SimpleTest]]: [MySQL] 1,708 pass(es).
[ View ]
#16 1774290-views-yamlindent-3.patch93.83 KBchrisjlee
FAILED: [[SimpleTest]]: [MySQL] 1,707 pass(es), 1 fail(s), and 338 exception(s).
[ View ]
#12 1774290-views-yamlindent-2.patch84.74 KBchrisjlee
PASSED: [[SimpleTest]]: [MySQL] 1,673 pass(es).
[ View ]
#9 1774290-views-yamlindent.patch81.52 KBchrisjlee
FAILED: [[SimpleTest]]: [MySQL] 1,629 pass(es), 1 fail(s), and 330 exception(s).
[ View ]
#7 1774290-yamlindent-4.patch44.21 KBchrisjlee
PASSED: [[SimpleTest]]: [MySQL] 1,632 pass(es).
[ View ]
#4 1774290-yamlindent-3.patch43.79 KBchrisjlee
FAILED: [[SimpleTest]]: [MySQL] 1,632 pass(es), 0 fail(s), and 356 exception(s).
[ View ]
#2 1774290-yamlindent-2.patch40.75 KBchrisjlee
FAILED: [[SimpleTest]]: [MySQL] 1,615 pass(es), 10 fail(s), and 800 exception(s).
[ View ]
#1 1774290-yamlindent-views.settings.yml-1.patch1.21 KBchrisjlee
PASSED: [[SimpleTest]]: [MySQL] 1,632 pass(es).
[ View ]

Comments

chrisjlee’s picture

StatusFileSize
new1.21 KB
PASSED: [[SimpleTest]]: [MySQL] 1,632 pass(es).
[ View ]

Did the first and easiest one by hand. attached is the patch of views.settings.yaml

chrisjlee’s picture

Status:Active» Needs review
StatusFileSize
new40.75 KB
FAILED: [[SimpleTest]]: [MySQL] 1,615 pass(es), 10 fail(s), and 800 exception(s).
[ View ]

Reattached a new patch was able to use `sed` to retab all the files. including the one i did by hand in #2

For those curious it can be done this way:

sed -e 's/^/~/' -e ': r' -e 's/^\( *\)~    /\1  ~/' -e 't r' -e 's/~//' file-name.yaml

Status:Needs review» Needs work

The last submitted patch, 1774290-yamlindent-2.patch, failed testing.

chrisjlee’s picture

StatusFileSize
new43.79 KB
FAILED: [[SimpleTest]]: [MySQL] 1,632 pass(es), 0 fail(s), and 356 exception(s).
[ View ]
chrisjlee’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 1774290-yamlindent-3.patch, failed testing.

chrisjlee’s picture

Status:Needs work» Needs review
StatusFileSize
new44.21 KB
PASSED: [[SimpleTest]]: [MySQL] 1,632 pass(es).
[ View ]
damiankloip’s picture

Status:Needs review» Needs work

The tests pass and the patch looks clean :) so this would definitely be an RTBC patch. However, yesterday we converted all the views in tests to yaml/config too yesterday (sorry!). All of these are in the config directory of views_test_config module. Seems like you would be a good candidate to convert the rest to...

chrisjlee’s picture

Status:Needs work» Needs review
StatusFileSize
new81.52 KB
FAILED: [[SimpleTest]]: [MySQL] 1,629 pass(es), 1 fail(s), and 330 exception(s).
[ View ]

whoops well try again!

Status:Needs review» Needs work

The last submitted patch, 1774290-views-yamlindent.patch, failed testing.

tim.plunkett’s picture

Since you need to reroll, you should pull again because there was another yml file added in #1765824: Provide a way to map views fields to a certain meaning

chrisjlee’s picture

Status:Needs work» Needs review
StatusFileSize
new84.74 KB
PASSED: [[SimpleTest]]: [MySQL] 1,673 pass(es).
[ View ]
aspilicious’s picture

Status:Needs review» Reviewed & tested by the community

Lets commit this

dawehner’s picture

I just looked at the changes and you seem to have missed the files in views_test_data, do you want to change them as well?

chrisjlee’s picture

@dawehner Yeah sure no problem. i'll get it done during lunch time. Sorry i missed it.

chrisjlee’s picture

Status:Reviewed & tested by the community» Needs review
StatusFileSize
new93.83 KB
FAILED: [[SimpleTest]]: [MySQL] 1,707 pass(es), 1 fail(s), and 338 exception(s).
[ View ]

nevermind there are only a few files. so i'll try again with testbot...

Status:Needs review» Needs work

The last submitted patch, 1774290-views-yamlindent-3.patch, failed testing.

chrisjlee’s picture

Status:Needs work» Needs review
StatusFileSize
new97.05 KB
PASSED: [[SimpleTest]]: [MySQL] 1,708 pass(es).
[ View ]

Let me know if i missed any other files!

tim.plunkett’s picture

Status:Needs review» Needs work

Last bit, there are 8 files in the top level config directory:

config/views.settings.yml
config/views.view.archive.yml
config/views.view.backlinks.yml
config/views.view.comments_recent.yml
config/views.view.frontpage.yml
config/views.view.glossary.yml
config/views.view.taxonomy_term.yml
config/views.view.tracker.yml
chrisjlee’s picture

@tim i was told those were already completed... see #8.

I could try to reroll that patch (see #7 i converted all those files there as well when i didn't need to :) ) if you'd like too.

tim.plunkett’s picture

I think you misunderstood, sorry.
There are 3 directories with YAML in them:

config
tests/views_test_config/config
tests/views_test_data/config

Your patch in #18 does the second two fine, but is missing the first one.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new141.32 KB
FAILED: [[SimpleTest]]: [MySQL] 0 pass(es), 63 fail(s), and 0 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, yaml-2spaces.patch, failed testing.

tim.plunkett’s picture

Status:Needs work» Needs review
StatusFileSize
new141.32 KB
PASSED: [[SimpleTest]]: [MySQL] 1,708 pass(es).
[ View ]

Trying this.

tim.plunkett’s picture

Status:Needs review» Fixed

Committed!
http://drupalcode.org/project/views.git/commit/d4844a8

Thanks so much @chrisjlee, sorry for all of the confusion. Congratulations on your first Views commit!

chrisjlee’s picture

@tim.plunkett Awesome thanks! Hopefully many more.

Automatically closed -- issue fixed for 2 weeks with no activity.