By replacing the default user_register_submit function, logintoboggan breaks one of the functionality of users_registrationpassword.
The one broken is the configuration where the password is asked during registration but the user is left with status=0 until it is verified using the confirmation email (and a custom link created by user_registrationpassword module).
This is because logintoboggan always sets status depending on its configuration, even if I didn't activate any option regarding registration (I only use login part of logintoboggan).
I think this can be easily fixed by not always overriding status in the submit function.
Comment | File | Size | Author |
---|---|---|---|
#3 | logintoboggan_breaks-1773424-3.patch | 549 bytes | helmo |
#1 | patch-logintoboggan-1773424.diff | 450 bytes | bago |
Comments
Comment #1
bago CreditAttribution: bago commentedHere is my fix. I think it is safe to simply keep "status" as it is submitted in that case (like the default submit handler does).
Comment #2
cthshabel CreditAttribution: cthshabel commentedTHANK YOU so much for sharing this.
Sure enough this was the missing fix for me to get back on track.
Comment #3
helmo CreditAttribution: helmo at Initfour websolutions commentedThanks ... this still causes WTF moments and security problems.
I've updated the patch to conform to the codestyle, no other changes.
Comment #4
Rob C CreditAttribution: Rob C commentedBump / Can we get some feedback from a maintainer? / Thanks!
Comment #5
Rob C CreditAttribution: Rob C commentedAdding possible duplicate issue.
Comment #6
stevecowie CreditAttribution: stevecowie as a volunteer commentedApplied in dev. Apologies for the slow response.
Comment #8
stevecowie CreditAttribution: stevecowie as a volunteer commented