By replacing the default user_register_submit function, logintoboggan breaks one of the functionality of users_registrationpassword.

The one broken is the configuration where the password is asked during registration but the user is left with status=0 until it is verified using the confirmation email (and a custom link created by user_registrationpassword module).

This is because logintoboggan always sets status depending on its configuration, even if I didn't activate any option regarding registration (I only use login part of logintoboggan).

I think this can be easily fixed by not always overriding status in the submit function.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bago’s picture

Status: Active » Needs review
FileSize
450 bytes

Here is my fix. I think it is safe to simply keep "status" as it is submitted in that case (like the default submit handler does).

cthshabel’s picture

Issue summary: View changes

THANK YOU so much for sharing this.

Sure enough this was the missing fix for me to get back on track.

helmo’s picture

Version: 7.x-1.3 » 7.x-1.x-dev
Status: Needs review » Reviewed & tested by the community
FileSize
549 bytes

Thanks ... this still causes WTF moments and security problems.

I've updated the patch to conform to the codestyle, no other changes.

Rob C’s picture

Bump / Can we get some feedback from a maintainer? / Thanks!

Rob C’s picture

stevecowie’s picture

Status: Reviewed & tested by the community » Fixed

Applied in dev. Apologies for the slow response.

  • helmo authored 12d2f0a on 7.x-1.x
    Issue #1773424 by bago, helmo: Logintoboggan breaks...
stevecowie’s picture

Status: Fixed » Closed (fixed)