In the JS dependency patch I did not put the right names in the overlay module.

When you put the right names, it works much better :)

CommentFileSizeAuthor
core-js-unbreak-overlay-libraries.patch787 bytesnod_

Comments

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Damn js! :D

(This is tested!)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Normal » Critical
Status: Reviewed & tested by the community » Fixed

:(

This is like the second time in two weeks we've managed to do this. I wonder if there's any way we could add even a rudimentary test to make sure that the overlay JS is making its way into the page when Overlay module is enabled. Hrm.

Anyway, committed and pushed to 8.x. Thanks!

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

I wonder if there's any way we could add even a rudimentary test to make sure that the overlay JS is making its way into the page when Overlay module is enabled.

Just saw that comment and wanted to point to the fact that Libraries API (2.x) has these sort of pseudo-tests for checking that JavaScript and CSS is loaded. Specifically http://drupalcode.org/project/libraries.git/blob/refs/heads/7.x-2.x:/tes... should be useful for someone taking a stab at this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.