While working on #1120020: SQLite database locking errors cause fatal errors i found some erroneous static calls to PDO nonstatic methods (which will afaict thwrow exceptions in all cases, so setting critical).
Also some parent methods were called where i could not make sense of it.
Most fixes seem quite straightforward, others need some review.
sqlite\Connection::rollback() looks like a forgotten dup of its parent.
if we're at it, we should re-case all occurences of rollback to rollBack.
This surely needs review from someone that is deeper into DB, so i'm putting this into one issue instead of opening a handful.
Comments
Comment #1
geek-merlinComment #3
geek-merlinfound an omission, rerolled and of course made do-not-test
Comment #4
aspilicious commentedWhy do not test? o_O
Comment #5
JimmyAx commentedComment #6
webchickI'm not sure either. Here's a re-upload of alex's patch. Please do not credit me on commit.
Also, we are currently over thresholds. Is this actually a critical bug, worth stopping other D8 features from being committed until we solve it?
Comment #8
webchickWell I guess that's why. ;)
I'm going to pre-emptively reduce this in priority to "normal." If this is wrong, please re-adjust, and clarify using the guidelines at Priority levels of issues.
Comment #9
damien tournoud commentedMost of those are actually valid. They are not static calls, but direct calls to a method at one point in the inheritance tree (which PHP allows us to do).
For example:
DatabaseConnection::commit()(sub-class ofPDO) returns an exception, because we can't allow people to mess up the transaction stack by committing themselves. WhenDatabaseConnection_mysql(sub-class ofDatabaseConnection) needs to do the actual commit, it callsPDO::commit()directly.Comment #9.0
damien tournoud commentedadded critical
Comment #12
daffie commentedThe problem from the IS are already fixed in D8.
I created a new issue for renaming the Drupal\Core\Database\Connection::rollback() method to Drupal\Core\Database\Connection::rollBack(). See #2801899: Rename Drupal\Core\Database\Connection::rollback() to Drupal\Core\Database\Connection::rollBack().
Added in that issue that commit credits should be given to @axel.rutz.