Code looks like

  // This will perform a node_access check, so we don't have to.
  return ctools_context_create('user_edit_form', $account);
  return NULL;

And the last return is unnecessary.

double-returns-user_edit.patch458 bytesanon
PASSED: [[SimpleTest]]: [MySQL] 67 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more


merlinofchaos’s picture

Status: Needs review » Fixed

Committed and pushed.

Jorrit’s picture

Be aware that your commit ( contained more than just the above patch.

merlinofchaos’s picture

Huh. The other commit is intended, at least, but I thought they were separate. I must've messed up a commit command.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

andypost’s picture

Priority: Minor » Critical
Status: Closed (fixed) » Active

This commit introduces a huge performance regression with hook_process() fired for most of renderables. So better to revert it and split the hook into limited set of elements that allowed to accept class injections

andypost’s picture

This changes was from #1775660: Move the code for adding/removing classes from Panels to CTools that does get no testing and no profiling

andypost’s picture

Priority: Critical » Minor
Status: Active » Closed (fixed)