We've got a couple issues with the usually-hidden "Parent Fieldset" option. Since this is hidden with JavaScript 99% of the time, problems aren't huge. But:

A) We're currently checking a non-existant variable_get('webform_enable_fieldset', TRUE) variable. But since it defaults to TRUE, the option is always shown.
B) Even if this were checking correctly, we shouldn't hinge the "Parent" functionality on fieldsets alone, since other component types can providing parenting ability (such as vertical tabs added through Display Suite).

So overall the fix is quite simple, just remove the check entirely. I switched the is_array() check on the same line to !empty() to work better in situations when creating a new node that doesn't yet have $node->webform['components'] set at all yet.

webform_disabled_fieldset.patch1.58 KBquicksketch
Members fund testing for the Drupal project. Drupal Association Learn more


quicksketch’s picture

Status: Needs review » Fixed

Committed to 3.x and 4.x branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.