with the installation of Noggin version 7.x-1.1 the option to stretch the header image to 100% width does no longer work.

Theme: Pixture Reloaded 7.x-3.0-rc1
CSS Header Selector: #header .header-inner .clearfix or #header .header-inner

Browser: Chrome, Firefox, IE

Comments

hpaterek’s picture

hpaterek commented

Found the fix.

I removed the !important tag in the noggin.module file.

I do not know what I might have broken by removing this, but the header images now stretches over the width of the whole page again.

dnotes’s picture

dnotes commented

I can confirm this problem and fix using Firefox 15.0.1, with a custom theme and header selector.

giorgio79’s picture

giorgio79 commented

Yes, after removing the !important it works for me as well
Here is the end result:

$css = "$selector {background:url('$image_path') $all_attributes ;height:$height;-o-background-size:$width auto;-webkit-background-size:$width auto;-khtml-background-size:$width auto;-moz-background-size:$width auto;background-size:$width auto;background-origin:border-box;}";

  • JamesOakley committed 2ab48f2 on 7.x-1.x 
    Issue #1762176 by hpaterek: Remove !important from CSS so 100% image...
jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented
Version: 7.x-1.1 » 7.x-1.x-dev
Issue summary: View changes
Status: Active » Fixed

This was fixed in the dev release, but the module was rolled back to 7.x-1.1 so that an XSS vulnerability could be fixed without introducing other changes. Now 7.x-1.3 is released, I'm testing the changes introduced since 7.x-1.1 to make sure the bugs they were designed to fix are indeed fixed without regressions.

This issue was never closed when this was fixed last time. I've now committed a patch that fixes this, so marking this issue as Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.