During my work on #1759004: apachesolr_search_custom_page_search_form_submit() kills all $_GET parameters I found some search form code which seems to be obsolete since search pages have been introduced. Am I right?

CommentFileSizeAuthor
#6 1759190-6.patch2.65 KBnick_vh
obsolete_form_code.patch3.12 KBmkalkbrenner

Comments

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

see #1733644: What $form_id can I use to theme the search form using form_alter?

pwolanin’s picture

pwolanin commented

obsolete_form_code.patch queued for re-testing.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Reviewed & tested by the community

tested this, good to go in

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

committed

pwolanin’s picture

pwolanin commented

So, do we still need it in 6.x-3.x? I know in 6.x-1.x we had to replace the core form.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1759190-6.patch2.65 KB

No longer needed as we dont use the form from the search/node page anymore.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Fixed

fixed

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Fixed » Closed (fixed)

closing to clear out the issue queue a bit