The theme settings form has some redundant CSS dating from D6.
Logo image settings has a "theme-settings-bottom" class which was used to apply clear:both to the fieldset, to stop it floating against the Toggle display fieldset.
It's no longer needed since we took away the "Display post information on" fieldset in D7 and made the Toggle display fieldset full-width.
It's not causing any problems in D7 / D8 core, but it is causing an issue for one of my modules in contrib (see #1757690: Big white space before the widgets in the "Logo image settings" vertical tab).
| Issue category | Task |
|---|---|
| Unfrozen changes | Unfrozen because it only removes unused CSS. |
Comments
Comment #1
andrewmacpherson commentedPatch for D8
Comment #2
andrewmacpherson commentedPatch for D7
Comment #4
andrewmacpherson commentedSorry, I think I was a bit too eager to mark this for D7 backport. After reading the backport policy, it seems that markup changes can only be accepted if it's a critical issue.
Uploading the D8 patch from #1 again, so the testbot knows which one to test.
Comment #5
andrewmacpherson commentedComment #6
klonosAs for the D7 backport and only critical issues accepted: does that apply to even such minor changes? I mean it is code that is not used after all.
Comment #7
mukeysh commented2: themesettings-CSS-cleanup-D7-1759090-2.patch queued for re-testing.
Comment #9
manjit.singh4: themesettings-CSS-cleanup-D8-1759090-4.patch queued for re-testing.
Comment #11
internetdevels commentedComment #12
jhedstromPatch no longer applies.
Comment #13
manjit.singhWhere to find theme settings file ?
Comment #14
jhedstromThe theme settings form moved to
core/modules/system/src/Form/ThemeSettingsForm.php.Comment #15
jjcarrionI have just made the reroll
Comment #16
jhedstromThis removes old CSS and an unused class, which is allowed as cleanup under the beta phase.
Comment #17
alexpottCommitted d61f619 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation for to the issue summary.