the status images in Node Sources View are replaced with HTML Icons analog to the review pane.

See attached screenshot with all colors. the corresponding status is in the node title.

Comments

berdir’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, icons_node_source_page.patch, failed testing.

berdir’s picture

Looks nice, maybe a bit too bold?

When you have a patch with binary files (the images), then you need to use --binary.

+++ b/ui/includes/tmgmt_ui.theme.incundefined
@@ -75,27 +79,28 @@ function theme_tmgmt_ui_translation_language_status_single($variables) {
+  ¶
+  //add classes to show the correct html icon
+  $classes = array();
+  $classes[] = 'tmgmt-ui-icon';
+  $classes[] = 'tmgmt-ui-icon-16'; // Icon size 16px square.
+  $classes[] = $icon_color;
+
+  //load css file, @TODO: find the right place to load this
+  drupal_add_css(drupal_get_path('module', 'tmgmt_ui') . '/css/tmgmt_ui.admin.css');

Comments should always be on a separate line and be formatted like this:

"// Start with a space and uppercase character and end with a dot."

cgalli’s picture

Status: Needs work » Needs review
StatusFileSize
new7.23 KB

Reduced Icon Size to 10px
Added left margin
Corrected the code style
git diff with --binary

Status: Needs review » Needs work

The last submitted patch, icons_node_source_page.patch, failed testing.

cgalli’s picture

StatusFileSize
new9.05 KB

Updated tests

cgalli’s picture

Status: Needs work » Needs review
StatusFileSize
new9.05 KB
cgalli’s picture

StatusFileSize
new9.05 KB
miro_dietiker’s picture

Don't use the tag field as comment field...

cgalli’s picture

StatusFileSize
new9.05 KB

Another Try.

berdir’s picture

This isn't being tested because the branch test failed, there's no need to re-upload the same patch :)

Status: Needs review » Needs work

The last submitted patch, icons_node_source_page.patch, failed testing.

berdir’s picture

Looks like the labels are different. If that's supposed to be like that, you just need to fix the expected label strings in the test.

cgalli’s picture

Status: Needs work » Needs review
StatusFileSize
new9.08 KB

Adapted the labels in the test

berdir’s picture

Status: Needs review » Fixed

Thanks, commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.