Test coverage for Editing and re-saving a node with tagged taxonomy terms removes terms from node

Here is a test.
The bug is not in D7, but it could use the test coverage.

Here's the save edit/save code for options_select which passes, proving that it's just the autocomplete that's broken

As this can easily cause data loss, this is sadly a critical.

This was broken by #1616972: Replace $term->name with $term->label().

Turns out it was a really easy fix!

taxonomy_implode_tags() was switched from
if (isset($tag->name)) {
to
if ($tag instanceof EntityInterface && $label = $tag->label()) {

But without the use statement, the EntityInterface prevented any terms from being loaded.

Whoops, should have been assertRaw.

I can confirm #8 corrects the issue. Before applying it, if you entered tags into a term reference field, saved the node, and then edited it again, the field would be blank. After applying the patch, the tags appear correctly in the edit form.

RTBC +1. Fix makes sense and has tests. Backport tag is for the tests, the bug doesn't exist there.

Looks good!

Wow, nice find. Glad we have test coverage for this embarrassing bug now.

Committed and pushed to 8.x. Thanks!

Moving to 7.x for backport of the tests, and reducing in priority as a result.

Backported the tests from #8 to D7.

13: taxonomy-tests-1754070-13.patch queued for re-testing.

Assuming this passes, I can't see why this wouldn't be RTBC.

13: taxonomy-tests-1754070-13.patch queued for re-testing.

That's yet another random test failure. >.>