Sorry for the ambiguous issue title, but this view field description needs to be altered:

Provide text to display if this field returns no results. You may include HTML. You may enter data from this view as per the "Replacement patterns" in the "Rewrite Results" section below.

CommentFileSizeAuthor
#11 views_field_desc-7.x-1751460-11.patch832 bytessphism
#4 views_field_desc-1751460-4.patch926 bytessphism
#1 views_field_desc-1751460.patch925 bytessphism

Comments

sphism’s picture

sphism commented
StatusFileSize
new views_field_desc-1751460.patch925 bytes

Here's a patch to change it

sphism’s picture

sphism commented
Status: Active » Needs review

... and it needs review

cvangysel’s picture

cvangysel commented
Status: Needs review » Needs work 
+++ b/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -1036,7 +1036,7 @@
+      '#description' => t('Provide text to display if this field returns an empty result. You may include HTML. You may enter data from this view as per the "Replacement patterns" in the "Rewrite Results" section below.'),

Yeah, I don't like the semantics of "returning". In my opinion it would be better to say that a field can "contain" an empty result.

sphism’s picture

sphism commented
Status: Needs work » Needs review
StatusFileSize
new views_field_desc-1751460-4.patch926 bytes

Yeah sounds good

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +VDC
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs backport to D7

From my perspective this is RTBC

aspilicious’s picture

aspilicious commented

#4: views_field_desc-1751460-4.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Title: The following field description needs to be updated » Clarify the empty result settings description on fields
Version: 8.x-3.x-dev » 7.x-3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Congratulations for your commit on views! Committed and pushed to 8.x-3.x

I think this would be helpful for 7.x as well.

sphism’s picture

sphism commented

Thanks Dawehner :)

So now it's committed, this issue gets changed to a version 7.x bug for a backport... then i just post patches in this same thread?

I'll do this next week.

dawehner’s picture

dawehner
Primary language German
commented

Exactly!

sphism’s picture

sphism commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new views_field_desc-7.x-1751460-11.patch832 bytes

This is a patch fo 7.x... should work

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

Perfect, thank you! Committed to 7.x-3.x and pushed.

sphism’s picture

sphism commented

Woohoo. Thanks for attributing the commit to me, very exciting that it shows up in my user profile :)

It's really encouraging to get the hang of the issue queue and patching simple issues, hopefully now i'll be able to help out with some trickier issues. I write a lot of drupal code as part of my day job.

I'll have a look in the issue queue, but if you think of something a bit trickier but still manageable then let me know.

Really enjoyed meeting you at drupalcon by the way :)

dawehner’s picture

dawehner
Primary language German
commented

@sphism
I try to create tasks for problems in the current code/things which should be done,
so if you want to work on something assign the issue to yourself. If you need any kind of help, don't hesitate to ask in irc.

http://drupal.org/project/issues/search/views?issue_tags=VDC is probably the best way to find issues to work on.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.