Basically $comment->subject should use $comment->label() and $comment->cid should use $comment->id();

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lunaris’s picture

Status: Active » Needs review
FileSize
4.8 KB

A first attempt.

Status: Needs review » Needs work

The last submitted patch, views-entity_interface-1748114-1.patch, failed testing.

dawehner’s picture

+++ b/modules/aggregator/views_handler_filter_aggregator_category_cid.incundefined
+++ b/modules/aggregator/views_handler_filter_aggregator_category_cid.incundefined
@@ -20,7 +20,7 @@ class views_handler_filter_aggregator_category_cid extends views_handler_filter_

You seems to have made a patch against 7.x-3.x :(

+++ b/modules/comment/views_plugin_row_comment_rss.incundefined
@@ -43,7 +43,7 @@ class views_plugin_row_comment_rss extends views_plugin_row {
-      $cids[] = $row->cid;

At this position it is still something from the db so you can't call cid()

+++ b/modules/comment/views_plugin_row_comment_view.incundefined
@@ -76,7 +76,7 @@ class views_plugin_row_comment_view extends views_plugin_row {
+      $cids[] = $row->id();

Also pure db

+++ b/modules/aggregator/views_handler_filter_aggregator_category_cid.incundefined
@@ -20,7 +20,7 @@ class views_handler_filter_aggregator_category_cid extends views_handler_filter_
     foreach ($result as $category) {
-      $this->value_options[$category->cid] = $category->title;
+      $this->value_options[$category->id()] = $category->title;

The $category is as that moment a pure result from the database.

lunaris’s picture

Status: Needs work » Needs review
FileSize
3.37 KB

God I'm an idiot. I think this one is a little better.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me

dawehner’s picture

Status: Reviewed & tested by the community » Fixed

Great, thank you!

Committed to 8.x-3.x

Automatically closed -- issue fixed for 2 weeks with no activity.