Views handler doesn't store the field instance in the object, so it's hard to reuse [#1741216]

When I worked on #1439838: Views support I saw that views doesn't pass the instance. The attached patch adds the instance to the handler.

Comment	File	Size	Author
#6	views-pass_field_instance-1741216-6.patch	2.27 KB	yannickoo
#6
#5	views-pass_field_instance-1741216-5.patch	1.6 KB	yannickoo
#5
#3	views-pass_field_instance-1741216-3.patch	1.65 KB	yannickoo
#3
#1	views-pass_field_instance-1741216-1.patch	1.32 KB	yannickoo
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

yannickoo

Berlin

CreditAttribution: yannickoo commented 20 August 2012 at 15:39

Status:

Active

» Needs review

File	Size
views-pass_field_instance-1741216-1.patch	1.32 KB

Comment #2

dawehner

German

CreditAttribution: dawehner commented 20 August 2012 at 17:45

Status:

Needs review

» Needs work

+++ b/modules/field/views_handler_field_field.incundefined
@@ -450,10 +450,10 @@ class views_handler_field_field extends views_handler_field {
+    $this->instance = ctools_fields_fake_field_instance($this->definition['field_name'], '_dummy', $formatter, $settings);

It would be cool if you could document the $this->instance variable on the actual class.

Comment #3

yannickoo

Berlin

CreditAttribution: yannickoo commented 20 August 2012 at 20:42

Status:

Needs work

» Needs review

File	Size
views-pass_field_instance-1741216-3.patch	1.65 KB

So, just updated the patch, included the documentation and the patch from #1741242: Replace _dummy view mode with _custom. BTW don't forget to attribute authorship ;)

Comment #4

dawehner

German

CreditAttribution: dawehner commented 20 August 2012 at 21:10

Title:	Views handler doesn't pass the field instance	» Views handler doesn't store the field instance in the object, so it's hard to reuse
Status:	Needs review	» Needs work

Based on the recent update you did with the _dummy change this patch does not apply anymore.

This should you to remember to keep patches seperated.