The use of format_plural() for showing a string as either singular or plural is wrong, as long as the strings don't contain any count. At the moment a block title is set as follows:

$block->title = format_plural(count($terms), 'Parent term', 'Parent terms');

Neither contain a count. Instead the translation should be:

$block->title = count($terms) == 1 ? t('Parent term') : t('Parent terms');

When using format_plural() will make the po files both contain a normal translation of 'Parent term' and a format_plural version, which as the documentation states is wrong: "Since t() is called by this function, make sure not to pass already-localized strings to it."

ctools-format_plural_parent_terms.patch639 byteslund.mikkel
PASSED: [[SimpleTest]]: [MySQL] 67 pass(es). View


merlinofchaos’s picture

Status:Needs review» Fixed

Seems reasonable. Committed and pushed.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.