Drupal Association members fund grants that make connections all over the world.
There are now several instances in boostrap.inc that use $GLOBALS['drupal_hash_salt'] - apparently we don't want to call drupal_get_hash_salt() because that function is in common.inc. However, if an admin accidentally left the variable empty, this could lead to the site being vulnerabile to some attacks this value is meant to protect against. Thus, we should move the function to bootstrap.inc and use it everywhere instead of the global.
In addition, we use Database::getConnectionInfo('default') instead of $databases in drupal_get_hash_salt() since $databases reflects the parent site, not the system-under-test when in a Simpletest run. See DrupalWebTestCase::changeDatabasePrefix.
PASSED: [[SimpleTest]]: [MySQL] 40,429 pass(es). View
PASSED: [[SimpleTest]]: [MySQL] 54,276 pass(es). View
PASSED: [[SimpleTest]]: [MySQL] 53,590 pass(es). View
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1739986_0_0.patch. Unable to apply patch. See the log in the details link for more information. View
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed. View