Since we have a $flagging entity to hand at the point when we invoke hook_flag_(un)flag(), we might as well pass it to the hook rather than just the id.

CommentFileSizeAuthor
#3 1736352.flag_.pass-flagging-to-hook-flag-flagunflag.patch3.62 KBjoachim

Comments

joachim’s picture

joachim commented
Issue tags: +1.0 blocker

Tagging.

joachim’s picture

joachim commented
Issue tags: -1.0 blocker +7.x-3.0-alpha1 blocker

Wrong tag.

joachim’s picture

joachim commented
Status: Active » Needs review
Issue tags: +Needs change record
StatusFileSize
new 1736352.flag_.pass-flagging-to-hook-flag-flagunflag.patch3.62 KB

Status: Needs review » Needs work
Issue tags: -Needs change record, -7.x-3.0-alpha1 blocker

The last submitted patch, 1736352.flag_.pass-flagging-to-hook-flag-flagunflag.patch, failed testing.

joachim’s picture

joachim commented
Status: Needs work » Needs review
Issue tags: +Needs change record, +7.x-3.0-alpha1 blocker

#3: 1736352.flag_.pass-flagging-to-hook-flag-flagunflag.patch queued for re-testing.

(I forgot to git push an earlier patch this depends on.)

joachim’s picture

joachim commented
Status: Needs review » Fixed

The testbot actually reports this as passing if you follow the link.

Issue #1736352 by joachim: Changed hook_flag_flag()/hook_flag_unflag() to receive the flagging entity instead of the id.

Added to change notification http://drupal.org/node/1734814

Automatically closed -- issue fixed for 2 weeks with no activity.