$form['display']['link_type'] = array(
    '#type' => 'radios',
    '#title' => t('Link type'),
    '#options' => _flag_link_type_options(),
    '#option_descriptions' => _flag_link_type_descriptions(),
    '#flag_link_fields' => _flag_link_type_fields(),
    '#after_build' => array('flag_expand_link_option', 'flag_check_link_types'),
    '#default_value' => $flag->link_type,
    '#weight' => 2,
    '#access' => empty($flag->locked['link_type']),
  );

What is '#flag_link_fields'? It doesn't seem to get used anywhere further along the form process.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim’s picture

Category: bug » task
Priority: Normal » Minor
Issue tags: +Novice

Looks like this was part of a system that was replaced in #873716: Fix the link-options dependency mechanism with the current fieldset visibility.

We can remove this property, and also _flag_link_type_fields() which is only called for this.

Tagging as novice.

pebosi’s picture

Status: Active » Needs review
FileSize
1.09 KB
1.15 KB
1.14 KB

Adding patches

joachim’s picture

Status: Needs review » Fixed

Thanks for the patches! Committed to 3.x.

Issue #1734550 by pebosi: Removed unused form property '#flag_link_fields' and helper function."

Will do the 2.x commits later.

joachim’s picture

Version: 7.x-3.x-dev » 7.x-2.x-dev
Status: Fixed » Needs review
bleen’s picture

#2: flag-1734550-7.x-2.x.patch queued for re-testing.

joachim’s picture

Thanks!

I'm not sure about the 6.x patch, as it may well be that this property actually does something on that branch!

joachim’s picture

Status: Needs review » Fixed

Pushed to both 2.x branches.

Thanks again!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Edited