Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
$form['display']['link_type'] = array(
'#type' => 'radios',
'#title' => t('Link type'),
'#options' => _flag_link_type_options(),
'#option_descriptions' => _flag_link_type_descriptions(),
'#flag_link_fields' => _flag_link_type_fields(),
'#after_build' => array('flag_expand_link_option', 'flag_check_link_types'),
'#default_value' => $flag->link_type,
'#weight' => 2,
'#access' => empty($flag->locked['link_type']),
);
What is '#flag_link_fields'? It doesn't seem to get used anywhere further along the form process.
Comment | File | Size | Author |
---|---|---|---|
#2 | flag-1734550-6.x-2.x.patch | 1.14 KB | pebosi |
#2 | flag-1734550-7.x-2.x.patch | 1.15 KB | pebosi |
#2 | flag-1734550-7.x-3.x.patch | 1.09 KB | pebosi |
Comments
Comment #1
joachim CreditAttribution: joachim commentedLooks like this was part of a system that was replaced in #873716: Fix the link-options dependency mechanism with the current fieldset visibility.
We can remove this property, and also _flag_link_type_fields() which is only called for this.
Tagging as novice.
Comment #2
pebosi CreditAttribution: pebosi commentedAdding patches
Comment #3
joachim CreditAttribution: joachim commentedThanks for the patches! Committed to 3.x.
Issue #1734550 by pebosi: Removed unused form property '#flag_link_fields' and helper function."
Will do the 2.x commits later.
Comment #4
joachim CreditAttribution: joachim commentedComment #5
bleen CreditAttribution: bleen commented#2: flag-1734550-7.x-2.x.patch queued for re-testing.
Comment #6
joachim CreditAttribution: joachim commentedThanks!
I'm not sure about the 6.x patch, as it may well be that this property actually does something on that branch!
Comment #7
joachim CreditAttribution: joachim commentedPushed to both 2.x branches.
Thanks again!
Comment #8.0
(not verified) CreditAttribution: commentedEdited