Hi there,

I've noticed that the "Results per page" option for a search page is broken.

The problem seems to occur at line 979 of apachesolr_search.module - the $params are correctly set in apachesolr_drupal_query() on line 978, but the 'rows' parameter is overwritten in apachesolr_search_basic_params(), meaning that all search pages are set to the default of 10 per page, regardless of the setting defined when editing the search page options.

CommentFileSizeAuthor
#6 1729836-test-only-6.patch1.65 KBpwolanin
#6 1729836--6.patch2.43 KBpwolanin
#3 1729836-3.patch801 bytespwolanin

Comments

nyleve101’s picture

nyleve101 commented

Glad to know this isn't just poor configuration on my part.

pwolanin’s picture

pwolanin commented

Ah, this probably relates to a small change Nick made recently before rc3.

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new 1729836-3.patch801 bytes

I think this fixes it.

nyleve101’s picture

nyleve101 commented

Thanks a lot pwolanin that did fix it!

pwolanin’s picture

pwolanin commented

Would be nice to add a test case, maybe using the mock solr class just to be sure...

pwolanin’s picture

pwolanin commented
StatusFileSize
new 1729836--6.patch2.43 KB
new 1729836-test-only-6.patch1.65 KB

test-only patch and test + fix patch

pwolanin’s picture

pwolanin commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

committed to 7.x

pwolanin’s picture

pwolanin commented
Status: Patch (to be ported) » Fixed

#3 applied to 6.x-3.x and committed.

pwolanin’s picture

pwolanin commented

actually, test changes apply too - also committed those to 6.x-3.x

jordanmagnuson’s picture

jordanmagnuson commented
Version: 6.x-3.x-dev » 7.x-1.0-rc3

Just wanted to note that this is also an issue in 7.x-1.0-rc3 (as pwolanin alluded to above), but fixed in the latest dev. Seems like a rather large issue for a release candidate... perhaps rc4 should follow soon?

pwolanin’s picture

pwolanin commented
Version: 7.x-1.0-rc3 » 7.x-1.x-dev

YEs, we are hoping to have another release (maybe 1.0) soon. Please file your bug reports now!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Added the name of the file with the problem code