The _marksmarty_process() function always loads both markdown and smartypants includes instead of only loading them if those filters are enabled. For obvious performance benefits they should be required inside the feature check.

The attached patch does that and a whitespace fix snuck in there also.

CommentFileSizeAuthor
marksmarty.module_1.patch1.27 KBtangent
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

why would the process hook get called for filters which are inactive? i haven't researched this but i bet you have.

milianw’s picture

milianw CreditAttribution: milianw commented

The issue is valid, and the patch ready to be committed in my eyes. I've implemented it in my patch as well, see http://drupal.org/node/220156 .

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Reviewed & tested by the community » Patch (to be ported)

fixed in HEAD

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Patch (to be ported) » Fixed

committed to DRUPAL-5 as well.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.