Right now, Fieldable panels panes has a dependency Field UI which is a module you should be able to disable on production sites. IMHO, it's in the same category as Views UI, Rules UI and probably a couple of others in contrib as well. While I agree that without Field UI, a new bundle is pretty much worthless, you could argue the same for a new content type which would only have a title and a body.

Also, the patch over at #1618308: User interface for managing bundles does a module_exists('field_ui') for the 'Save and add fields' button.
That would make it consistent, otherwise, that line is redundant.

Patch coming up.

CommentFileSizeAuthor
#8 fieldable_panels_panes-n1724394-8.patch3.65 KBdamienmckenna
#3 1724394-3.patch1.42 KBswentel
#1 1724394-1.patch974 bytesswentel

Comments

swentel’s picture

swentel commented
Status: Active » Needs review
StatusFileSize
new 1724394-1.patch974 bytes
merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

I think we will need a module_exists('field_ui') around the code that adds the field UI based menus or we will get whitescreens.

swentel’s picture

swentel commented
Status: Needs work » Needs review
StatusFileSize
new 1724394-3.patch1.42 KB

New patch checking on field ui module in fieldable_panels_panes_admin_menu_map()

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

#3 wasn't correct either. The end of the function contains non-field UI module related menu paths that are still safe to add. I limited it to specifically the field links that are added under 'Manage fields' and it seemed to work great. Committed to 7.x-1.x.
http://drupalcode.org/project/fieldable_panels_panes.git/commit/3d73b08

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

recidive’s picture

recidive commented
Issue summary: View changes
Status: Closed (fixed) » Needs work

There's still one dependency on field ui that's causing this error:

PHP Fatal error: Call to undefined function _field_ui_bundle_admin_path() in /mnt/www/html/my-site/docroot/profiles/my-profile/modules/contrib/fieldable_panels_panes/plugins/export_ui/fieldable_panels_pane.class.php on line 205 request_id="v-ad20f450-8715-11e5-a77d-22000a9f02f0"

This is the line that adds the dependency:

http://cgit.drupalcode.org/fieldable_panels_panes/tree/plugins/export_ui...

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +undefined

And some tests would help ;-)

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
Issue tags: -undefined
StatusFileSize
new fieldable_panels_panes-n1724394-8.patch3.65 KB

There were a few other places that Field UI was assumed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The code that refers to _field_ui_bundle_admin_path() shouldn't run if Field UI isn't enabled because the "Save and continue" button will only exist on the "Add a new fieldable panels panes type" form if Field UI is enabled.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2679603: Plan for Fieldable Panels Panes 7.x-1.9

  • DamienMcKenna committed f1588e1 on 7.x-1.x 
    Issue #1724394 by DamienMcKenna: Hide some links if Field UI is not...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.