Hooks with an $op parameter are soooooooooo Drupal 6 man.

Let's split this into hook_flag_flag() and hook_flag_unflag().

CommentFileSizeAuthor
#2 1720402.flag_.kill-hook-flag.patch5.2 KBjoachim

Comments

joachim’s picture

joachim commented

Should do #1720196: invoke Rules event alongside rather than within hook invocation first, which will simplify this one.

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 1720402.flag_.kill-hook-flag.patch5.2 KB

Let's see what the testbot says.

joachim’s picture

joachim commented
Status: Needs review » Fixed

Issue #1720402 by joachim: Split hook_flag() into hook_flag_flag() and hook_flag_unflag().

Committed with a couple of tweaks:

- api.php file still had hook_flag() instead of hook_flag_flag().
- added note to flag_flag_trigger() to explain it's a helper function

And finally: http://en.wikipedia.org/wiki/James_while_John_had_had_had_had_had_had_ha... ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.