$_SERVER use in openpublish.profile and drush use [#1719808]

I have a small issue with OpenOutreach and learned the code came from OpenPublish so here I am. Detail: #1718248: $_SERVER use in openoutreach.profile and drush use

I get these notices on cron runs (drush cron --debug):

Undefined index: SERVER_NAME openoutreach.profile:121
Undefined index: SERVER_ADDR openoutreach.profile:122

I grepped for the server_ip index and don't see anywhere it's used. But that leaves the server_name index, which I believe is needed but this is Apps thing all new territory for me.

In function openpublish_apps_servers_info(), how are the server_name and server_ip indexes used?

Comments

Comment #1

Robin Millette CreditAttribution: Robin Millette commented 9 August 2012 at 05:27

Title:

$_SERVER use in openoutreach.profile and drush use

» $_SERVER use in openpublish.profile and drush use

Comment #2

jec006 CreditAttribution: jec006 commented 12 September 2012 at 14:35

Status:

Active

» Fixed

Hi Robin,

I fixed the issue here: http://drupalcode.org/project/openpublish.git/commit/5b55dd0 and added some better comments. That info is just used to identify the site to the appserver so things like voting can work (and any other functionality which might require to know what site is telling it what).

Thanks.