Problem/Motivation

Currently, the devel module installs and uses its own FirePHP library located in the Drupal libraries path. If FirePHP is already installed using PEAR, it would be preferable to use that instead. I manage my own FirePHP (and Drush) library installations using PEAR and would prefer if they were used over the versions found in the Drupal libraries path.

Proposed resolution

During initialisation of the devel module, a check should be done to see if FirePHP is already available in the default PEAR installation path. This PEAR library path is already added to the PHP include path, so the FirePHP PEAR library can always be found in the FirePHPCore subdirectory of that PEAR library path.

Remaining tasks

  1. Update the Drush pm-download code so that if a PEAR install of FirePHPCore is found, the library isn't downloaded and added to the Drupal libraries path too.
  2. It may be helpful to document this somewhere so that users understand which FirePHP library will be used, in order of precedence, if more than one exists on a system.

Comments

chop’s picture

Status: Active » Needs review
StatusFileSize
new474 bytes

This patch modifies the include check already present in devel_init so that it now looks for FirePHP in the standard PEAR installation path at FirePHPCore/fb.php

moshe weitzman’s picture

Status: Needs review » Fixed

Looks good, but there is a file permissions mode change in the patch ... I just went ahead and made the change manually. Committed to 8.x and 7.x.

chop’s picture

Sorry, first time rolling a patch with git. I didn't even know that file permission changes could be incorporated in a patch file.
I'll watch for that in future.

chop’s picture

StatusFileSize
new449 bytes

I recreated this patch for myself, removing the file permissions mode change, so I could apply it until this change is released.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Added another remaining task