Hi,

Just trying to clean up again.. :D I have this attitude to try to search on functions that I haven't encountered yet. Anyway, there's a typo on the comments for taxonomy_get_tree.

CommentFileSizeAuthor
#8 taxonomy-docu-1715326-8.patch739 bytesoriol_e9g
#6 taxonomy-get_tree-typo-1715326-6.patch766 byteskid_icarus
#4 taxonomy-get_tree-typo-1715326-4.patch757 byteskid_icarus
#4 interdiff.txt653 byteskid_icarus
get_tree-typo-0.patch697 bytesdsdeiz

Comments

marcin.wosinek’s picture

marcin.wosinek commented
Component: taxonomy.module » documentation
Status: Needs review » Reviewed & tested by the community

Looks good for me.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Good catch. Committed to 8.x. Thanks.

David_Rothstein’s picture

David_Rothstein commented
Status: Fixed » Needs work
Issue tags: +Needs backport to D6, +Needs backport to D7

This should be backported, but the code comment needs to wrap at 80 characters (http://drupal.org/node/1354#general).

kid_icarus’s picture

kid_icarus commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt653 bytes
new taxonomy-get_tree-typo-1715326-4.patch757 bytes

Here you go :)

Status: Needs review » Needs work

The last submitted patch, taxonomy-get_tree-typo-1715326-4.patch, failed testing.

kid_icarus’s picture

kid_icarus commented
Status: Needs work » Needs review
StatusFileSize
new taxonomy-get_tree-typo-1715326-6.patch766 bytes

Whoops, I was behind by a few commits. Re-rolled.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Needs review » Patch (to be ported)

Thanks! Committed this to 8.x (although it touches the same file as an "avoid commit conflicts" issue, it is in a different area of the file so it should be OK).

The patches above now need porting to D7.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new taxonomy-docu-1715326-8.patch739 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

That patch looks good to me, thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.