Pretty much a clone of this issue #1669918: Allow Panels to properly use Facet API blocks but for Current Search blocks

Currently, you cannot place a Facet API block above the actual search results in Panels.
Also, the blocks are listed under "Miscellaneous".

This, in conjunction with #1669908: hook_ctools_content_subtype_alter() does not run early enough, fixes this.

Files: 
CommentFileSizeAuthor
#6 facetapi-1710822-4.patch807 bytesdawehner
PASSED: [[SimpleTest]]: [MySQL] 566 pass(es).
[ View ]
#4 facetapi-1710822-4.patch789 bytesdawehner
PASSED: [[SimpleTest]]: [MySQL] 566 pass(es).
[ View ]
#1 facetapi_current_search-render-last.patch749 bytesnbucknor
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch facetapi_current_search-render-last.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

nbucknor’s picture

Status:Active» Needs review
StatusFileSize
new749 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch facetapi_current_search-render-last.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Status:Needs review» Needs work

The last submitted patch, facetapi_current_search-render-last.patch, failed testing.

alanom’s picture

Not sure if this is within the intended scope of this patch, but it didn't solve the problem for me setting panels in ctools Page Manager. Steps taken:

  • Applying this patch to latest facet API dev
  • Current Search below a context view of search results in page manager: works fine
  • Current Search above a context view of search results in page manager: renders nothing

Is the intention to fix this across the ctools/panels family, or just in setups made purely in the Panels module?

dawehner’s picture

Status:Needs work» Needs review
StatusFileSize
new789 bytes
PASSED: [[SimpleTest]]: [MySQL] 566 pass(es).
[ View ]

It worked for me without any problems once the patch got applied. Great idea to render it later!

Rerolled the patch so it should apply for the testbot.

cpliakas’s picture

Status:Needs review» Needs work

This looks good. Marking as needs work, only because "category" should probably be t('Current Search blocks') unless there is a good argument for it to be names otherwise. Once the change is made (or my suggestion is proven to be a bad one), I will be happy to roll the patch into Facet API!

Thanks for the contribution!
Chris

dawehner’s picture

StatusFileSize
new807 bytes
PASSED: [[SimpleTest]]: [MySQL] 566 pass(es).
[ View ]

When I first added the current search block in the panel I looked for facetapi (no special reason, just a first guess).

Everything is better then putting it into the miscell. category :)

cpliakas’s picture

Status:Needs work» Needs review
cpliakas’s picture

Status:Needs review» Reviewed & tested by the community
jaydub’s picture

Ran into this issue as well, patch works great!

paranojik’s picture

Works for me also. Thanks guys!

gmclelland’s picture

The patch in #6 worked for me. Thank you!

cpliakas’s picture

Status:Reviewed & tested by the community» Fixed

Looks good. Thanks for the patch and to all the testers! Committed to all branches of Facet API:

dawehner, congrats on becoming the 37th code contributor to Facet API!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.