Needs work
Project:
Chaos Tool Suite (ctools)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Aug 2012 at 03:13 UTC
Updated:
19 Jan 2016 at 17:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
begun commentedOriginally I was going to make this a separate issue. But since it is directly related to the patch mentioned previously, I shall instead post my followup patch into the original issue thread.
Comment #2
begun commentedI created a patch which I posted in the other issue thread mentioned above, however it keeps failing the automatted patch validation. I can successfully apply the patch on my own system. According to the patch validation log there is an error on line 363 of file modal.js.
I am at a bit of a loss as to what is wrong. Perhaps it has something to do with the fact that this patch relies on another patch first being applied. Don't know enough about the automatted patch validation process to know if this could be the cause.
Would be grateful if someone could point me in the right direction.
Comment #4
begun commentedAfter re-reading the patch file and the error message, I think the problem is might be due to the lack of a trailing comma on line 367 of the modal.js. Let's see if this works.
Comment #6
begun commentedThis time a will try merging the two patches into one, and see if that works.
Comment #7
begun commentedOK, that was it. Learned something about patch validation in the process. I think I will just leave this here rather than continuing to clutter up the the other issue thread.
Comment #7.0
begun commentedAdded more info.
Comment #7.1
begun commentedAdded missing link.
Comment #10
garbo commentedThis is still an issue with the ctools modal.
The modal becomes unusable when it is larger then the browser window.