By default a ctools dynamic modal is designed to remain centered in the browser window when the underlying page is scrolled. This results in problems when the height of the modal is greater than the height of the browser window. In such a case it becomes impossible to scroll to the bottom of the modal. I discovered this while testing 1294478-modal-dynamic-mode.patch from this issue thread.

Comments

begun’s picture

Status: Active » Closed (duplicate)

Originally I was going to make this a separate issue. But since it is directly related to the patch mentioned previously, I shall instead post my followup patch into the original issue thread.

begun’s picture

Status: Closed (duplicate) » Needs review
StatusFileSize
new3.07 KB

I created a patch which I posted in the other issue thread mentioned above, however it keeps failing the automatted patch validation. I can successfully apply the patch on my own system. According to the patch validation log there is an error on line 363 of file modal.js.

[23:12:32] Command [git apply --check -p1 /var/lib/drupaltestbot/sites/default/files/review/pin_oversized_dynamic_modal-1294478_1.patch 2>&1] failed
  Duration 0 seconds
  Directory [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/ctools]
  Status [1]
 Output: [error: patch failed: js/modal.js:363
error: js/modal.js: patch does not apply].

I am at a bit of a loss as to what is wrong. Perhaps it has something to do with the fact that this patch relies on another patch first being applied. Don't know enough about the automatted patch validation process to know if this could be the cause.

Would be grateful if someone could point me in the right direction.

Status: Needs review » Needs work

The last submitted patch, pin_oversized_dynamic_modal-1294478.patch, failed testing.

begun’s picture

Status: Needs work » Needs review
StatusFileSize
new2.75 KB

After re-reading the patch file and the error message, I think the problem is might be due to the lack of a trailing comma on line 367 of the modal.js. Let's see if this works.

Status: Needs review » Needs work

The last submitted patch, pin_oversized_dynamic_modal-1294478.patch, failed testing.

begun’s picture

Status: Needs work » Needs review
StatusFileSize
new11.37 KB

This time a will try merging the two patches into one, and see if that works.

begun’s picture

OK, that was it. Learned something about patch validation in the process. I think I will just leave this here rather than continuing to clutter up the the other issue thread.

begun’s picture

Issue summary: View changes

Added more info.

begun’s picture

Issue summary: View changes

Added missing link.

Status: Needs review » Needs work

The last submitted patch, 6: merged_dynamic_modal_and_pin_oversized_modal-1294478.patch, failed testing.

garbo’s picture

Issue summary: View changes

This is still an issue with the ctools modal.

The modal becomes unusable when it is larger then the browser window.