Problem/Motivation

Form builder component 'date' implementation uses the incorrect variable names for some parameters. The result of this is that 'year start' and 'year end' are not available to be edited in form builder.

Proposed resolution

Set the Variable names correctly. 'start_date' and 'end_date'

Remaining tasks

  • Confirm Patch

User interface changes

  • None

API changes

  • None

Original report by [arcticshadow]

CommentFileSizeAuthor
#1 incorrect_variable_names-1707090-1.patch1.15 KBarcticShadow

Comments

arcticShadow’s picture

arcticShadow commented
StatusFileSize
new incorrect_variable_names-1707090-1.patch1.15 KB

Attached Proposed fix

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Needs review

Thanks! I think you're quite right. I'll give this a review and commit next time I'm working on Form Builder.

arcticShadow’s picture

arcticShadow commented

It's pretty straight forward, But it will still be the first patch i have submitted. Please let me know if I have missed anything.

Cheers,

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Needs review » Reviewed & tested by the community

Good find @arcticShadow, code changes look good. Start date and End date show up and are correctly saved with the patch. RTBC.

quicksketch’s picture

quicksketch
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks guys! Also confirmed the fix and it works great. Committed to both branches of the project.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updating remaining tasks