This is a big patch and I know this is not very appreciated by the maintainers ;).
But most changed things are related and it was too difficult to isolate stuff while I was busy coding

Anyway, here are the things that are in the patch:

  • Added and worked on error checking an reporting. For example, the patch now even makes it impossible to select an image captcha when there is no font configured. Also solved a bug where the module would wrongly report that there was no font selected (typically during first configuration)
  • made image module utf friendly: module also works with non ASCII characters like ë, ç, á etc (see http://drupal.org/node/164616). Also added the check that there shouldn't be spaces in the character list (see http://drupal.org/node/169494)
  • Cleaned and streamlined the image generating code. There appeared to be a lot of cruft in the code and things could be done easier/more compact/more efficient.
  • Added an option for a less resource hungry image generation by disabling bilinear interpolation
  • Added options for the image captcha: font size, distortion level, noise level.
  • Added the example image again on the settings page, which makes it much easier to configure the image captcha (also see http://drupal.org/node/165577)
  • Solved problems reported by the coder module (also see http://drupal.org/node/170203)
  • various minor tweaks

I'll post a screenshot in follow up.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

soxofaan’s picture

FileSize
90.62 KB

screenshot of the patched image captcha settings page

drupalgirl’s picture

Thanks. Can we get instructions? How should it be applied? Where?

Drupalgirl

RobLoach’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
33.78 KB

Looks good!........ But I can't read the Captcha it generates (see screenshot) :-P .

soxofaan’s picture

New version of patch:
Added information in the help and description strings about CPU load of the image captcha generation and how to keep it constrained.
Added hint in description to not exaggerate the obfuscation settings. See#3 ;)
Added tiny font size (12pt) option.

soxofaan’s picture

FileSize
91.19 KB

screenshot of the settings page with the update of #4

soxofaan’s picture

Seems I need a spell checker in my editor.
Change all "intesive" to "intensive" (four times) in the patch from #4.
or use attached patch (against image_module version 1.1.4.11) instead of the one in #4.

At drupalgirl in #2: see http://drupal.org/patch/apply or wait until this patch is committed by the maintainers to the development branch.

RobLoach’s picture

Status: Reviewed & tested by the community » Needs review

Checking your #6 patch right now.

RobLoach’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

wundo’s picture

committed ;)

wundo’s picture

Status: Reviewed & tested by the community » Fixed

committed ;)

soxofaan’s picture

Status: Fixed » Reviewed & tested by the community
FileSize
3.73 KB

thanks guys!

but my patch seems to have messed up some indentation/whitespace
(I had wrongly -b and -B enabled as my default cvs options)
attached patch fixes that (no features added, just whitespace)

RobLoach’s picture

Title: major overhaul of image captcha » Major overhaul of image captcha - Whitespaced
Status: Reviewed & tested by the community » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)