Got this while testing the new '--all' option: every command logs a message with $object->name, however, this is not always set for every exportable. For inspiration we could look at ctools_export_default_list() which also uses the admin_title option. If no key is found, it just defaults to the export key which every exportable must have. This would also lead to some nicer output on the command line (eg, views will return the human_name instead of name).

For testing, use field_group or ds, both should default to the export key in the end (shame on me)

CommentFileSizeAuthor
#3 1700556-3.patch2.57 KBdamiankloip
#1 1700556.patch2.57 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
StatusFileSize
new 1700556.patch2.57 KB

fair observation, how about something like this?

swentel’s picture

swentel commented
Status: Needs review » Needs work

Looks good to me, other than a small typo - unless we're secretly going to use Police references in ctools :)

+++ b/drush/ctools.drush.incundefined
@@ -762,6 +769,23 @@ function _ctools_drush_export_module_filter(&$exportables, $export_module) {
+ * @return sting

Should be 'string'

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new 1700556-3.patch2.57 KB

haha, damn - you spotted it ;)

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community

Great :)

damiankloip’s picture

damiankloip commented
Status: Reviewed & tested by the community » Fixed

Committed: http://drupalcode.org/project/ctools.git/commit/159a52a

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.