title says it all. needs testing on mysql.

CommentFileSizeAuthor
pg_overview.patch564 byteshunmonk

Comments

aclight’s picture

Status: Needs review » Reviewed & tested by the community

Patch applies cleanly and appears to work fine with MySQL.

The only thing is that it's not clear to me how this patch makes the query pgsql compliant. My best guess is that n.sticky is one of the fields in the ORDER BY statement in project_project_sort_methods() and pgsql gives an error because that isn't one of the fields that is actually returned by the query because it's not in the SELECT statement?

If that's the case then I would say go with it. If not, it might be helpful to write a quick note here as to why this change makes the query pgsql compliant, in case someone looks back at this issue in the future for guidance or for an explanation.

hunmonk’s picture

Status: Reviewed & tested by the community » Fixed

correct, n.sticky must also be in the select b/c of ORDER BY.

fixed in HEAD, 4.7.x-2.x, 4.7.x-1.x

Anonymous’s picture

Status: Fixed » Closed (fixed)