Backport git version check on hook_requirements

Hi guys,

We're using git version 1.7.1, and when this module fetch commit operations it issues the following command, found in VersioncontrolGitRepositoryHistorySynchronizerDefault.class.php and the function parseAndInsertCommit():

<?php
$command = "show --numstat --summary --pretty=format:\"%H%n%P%n%an%n%ae%n%at%n%cn%n%ce%n%ct%n%B%nENDOFOUTPUTGITMESSAGEHERE\" " . escapeshellarg($hash);
?>

In our environment this seems to result in the "message" column of db-table "versioncontrol_operations" containing "%B" instead of the commit-message. I therefore started investigating the behavior, and in the process issued the command manually:

(I took the liberty of anonymizing it a little)

[root@server directory]# GIT_DIR=/my/git/repo/path/testing.git /path/to/bin/git show --numstat --summary --pretty=format:"%H%n%P%n%an%n%ae%n%at%n%cn%n%ce%n%ct%n%B%nENDOFOUTPUTGITMESSAGEHERE" '<hash1>'
<hash1>
<hash2>
<my username>
email@example.com
1341180316
<my username>
email@example.com
1341180316
%B
ENDOFOUTPUTGITMESSAGEHERE
2       1       testing.txt

Surely enough the %B seems present there too instead of the actual commit-message. So I decided to look up the manual on the "pretty" formating to double-check what the appropriate option/placeholder would be.

http://git-scm.com/book/en/Git-Basics-Viewing-the-Commit-History

This lists the available options/placeholders as:

Option  Description of Output
%H  Commit hash
%h  Abbreviated commit hash
%T  Tree hash
%t  Abbreviated tree hash
%P  Parent hashes
%p  Abbreviated parent hashes
%an Author name
%ae Author e-mail
%ad Author date (format respects the –date= option)
%ar Author date, relative
%cn Committer name
%ce Committer email
%cd Committer date
%cr Committer date, relative
%s  Subject

I assumed "Subject" is what we are after here - so I tested with that instead:

[root@server directory]# GIT_DIR=/my/git/repo/path/testing.git /path/to/bin/git show --numstat --summary --pretty=format:"%H%n%P%n%an%n%ae%n%at%n%cn%n%ce%n%ct%n%s%nENDOFOUTPUTGITMESSAGEHERE" '<hash1>'
<hash1>
<hash2>
<my username>
email@example.com
1341180316
<my username>
email@example.com
1341180316
ref [65] Another (2nd) commit to testing repo.
ENDOFOUTPUTGITMESSAGEHERE
2       1       testing.txt

And indeed it works!

Is there an error in your implementation of the "pretty" formating here, or have I missed something?

Perhaps there's been a change in format in later git versions?