I've successfully applied the patches from http://drupal.org/node/103171 and this module is working great for me. Thanks for the great module. I've got a few requests that I might be able to make some time to submit patches for.
The first is adding a " - Choose an action - " option in the VIEWS_BULK_OPS_STEP_VIEW action select box. The exact language and format could be different, but an initial "0" state that helps direct the user might be a good addition to the interface. This would probably also require a quick addition to the validate function.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | vbo_actionselect3.patch | 2.13 KB | seanbfuller |
| #3 | vbo_actionselect2.patch | 2.21 KB | seanbfuller |
| #1 | vbo_actionselect.patch | 2.2 KB | seanbfuller |
Comments
Comment #1
seanbfuller commentedHere's a small patch to add this functionality. I created a form element on the settings page where admins can define the text for this element. If this is left blank, the "0" state option is not added, leaving the functionality as-is. Needs review.
Comment #2
seanbfuller commentedJust realized that the previous patch had an error in how the text was being populated, resulting in it being hard-coded. Fixed and updated. Sorry about that.
Comment #3
seanbfuller commentedAnd here is the patch for the previous post.
Comment #4
seanbfuller commentedAfter more testing I found that the $options = array(); line was causing problems and broke the confirmation page (although I'm not sure why). I'm pretty sure this patch fixes the problem, but I'll report back if my bug shows up again.
This patch just removes that line. Up for review for whenever someone might need it.
Comment #5
infojunkieSimplified the patch into a hardcoded string that can be changed using the .po file mechanism. Should be good enough for now. Thanks for the effort.
Comment #6
(not verified) commented