Hi Jeremy,

You've blown me away with this fabulous module. Congratulations on an excellent, well thought out implementation.

I'd like to see more calls to db_rewrite_sql(). I found I needed to modify a few of the queries for a multi-site implementation. Specifically, lines 50, 69 & 85 of adserve.inc, but it's probably a good idea to use db_rewrite_sql() everywhere. What do you think?

Cheers,
caign

Comments

Jeremy’s picture

Jeremy CreditAttribution: Jeremy commented
Status: Active » Postponed (maintainer needs more info)

A patch would be welcome, as well as an explanation as to what you're accomplishing with the change.

Jeremy’s picture

Jeremy CreditAttribution: Jeremy commented
Status: Postponed (maintainer needs more info) » Postponed

Postponing this issue until someone contributes a good patch.

Jeremy’s picture

Jeremy CreditAttribution: Jeremy commented
Status: Postponed » Closed (won't fix)

No patches contributed, closing issue.