Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #1444866: UI for translation of menu items for entity-translated nodes.
EntityTranslationNodeHandler::menuFormSubmit()
contains the following @todo item:
@todo Remove this once hook implementation calling order is fixed.
I'm not sure what the exact problem was, but sounds like this needs fixing... :)
Comment | File | Size | Author |
---|---|---|---|
#2 | et-module_implements-1694480-2.patch | 10.53 KB | plach |
Comments
Comment #1
plachDon't remember exactly what that todo means, but it surely refers to implementing
hook_module_implements()
instead of relying on the module weight.Added this to the road map: #1624830: Plan for Entity Translation 7.x-1.0 release.
Comment #2
plachThe attached patch fixes the OP by implementing
hook_module_implements_alter()
. There is also some code moved around to clean up the hook implementation portion of the entity_translation.module. No code change there.Comment #3
plachAlso menu tests are green locally.
Comment #4
plachCommitted and pushed.
Comment #6
miro_dietikerDuplicated by #1345932: Replace fixed module weight with hook_module_implements_alter()
Comment #6.0
miro_dietikerAdded reference to original issue which added the @todo.