Title says it all; I have tested this and it seems we don't need this. So the current TODO is confirmed. I think this can go.

CommentFileSizeAuthor
admin_views.get_breadcrumbs.patch486 bytesdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Is the correct breadcrumb still displayed?

(Should we add a test for the breadcrumb? ;))

damiankloip’s picture

damiankloip commented

Yep, I tested this. The breadcrumb is still displayed. I will look at a test now, they aren't my strongest attribute though :)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Actually, scratch the tests.

Since the system display handler only replaces existing router paths, and because it's really only about the router item definition (not changing the link's title or other breadcrumbs-relevant properties), the regular breadcrumbs should totally work as usual.

damiankloip’s picture

damiankloip commented
Status: Reviewed & tested by the community » Active

ok, that makes sense. Committed to 7.x

damiankloip’s picture

damiankloip commented
Status: Active » Fixed

Oops.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.