When you edit the label of any environment it duplicate it because the env_id is the label. This is wrong, the right way is env_id to be autoincremental number as the node id, and an extra column for the label.

I'm doing the path. Need some time to figure out all the use of env_id.

CommentFileSizeAuthor
#4 1691208-4-D6x-3x.patch1.61 KBpwolanin
#1 env-id-1691208-1.patch5.48 KBkillua99

Comments

killua99’s picture

killua99 commented
Status: Active » Needs review
StatusFileSize
new env-id-1691208-1.patch5.48 KB

Please take a look, may be need work, or something new. When I apply this patch in my development env I need to resetting the default environment, and wich node to index and bias.

Status: Needs review » Needs work

The last submitted patch, env-id-1691208-1.patch, failed testing.

pwolanin’s picture

pwolanin commented

Yes, I think in 7.x we don't allow you to edit it - this is a bug for sure, and I just reproduced it

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new 1691208-4-D6x-3x.patch1.61 KB

Here's an updated patch - I think some of the other concerns are already resolved.

pwolanin’s picture

pwolanin commented
Title: When you edit an environment it create a duplicate if you edit the label » When you edit an environment it creates a duplicate if you edit the label
Status: Needs review » Fixed
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Fixed » Closed (fixed)