Refactor toolbar.js use localStorage remove cookie and no-js fallback [#1686256]

Can be written to minify much better, and use the same approach as #1569648: Follow-up: Use localStorage to store tableDrag.showWeight value for the display/toggle of the collapsing toolbar.

The cookie will still need to be used to keep the no-js fallback of the toggle, otherwise localStorage should be used to be able to toggle it on all open tabs. See how it's done on the other issue.

Comment	File	Size	Author
#2	1686256_toolbar_refactor_localstorage_2.patch	4.25 KB	frega

Comments

Comment #1

nod_

French

Lille

commented 15 July 2012 at 14:22

Title:

Refactor toolbar.js

» Refactor toolbar.js and make it use localStorage

Comment #2

frega commented 22 August 2012 at 09:49

Status:

Active

» Needs review

Status	File	Size
new	1686256_toolbar_refactor_localstorage_2.patch	4.25 KB

Refactored along the lines in #1569648: Follow-up: Use localStorage to store tableDrag.showWeight value.

Notes:
- displayToolbar is a bit of a misnomer for what that function does (redrawing/updating state)
- one could argue about having the toolbar not being a "static" class, but an instantiated singleton (but that's almost bikeshedding)

Comment #3

nod_

French

Lille

commented 22 August 2012 at 11:47

Status:

Needs review

» Needs work

That's a good start :)

There is a link in the toolbar module to have a php callback setting a cookie to provide a no-js toggle of this. So we have to work around that.

As far as review goes, I'd be happy with selecting the elements only once in the attach behavior and send that to the methods afterwards.

Comment #4

frega commented 22 August 2012 at 12:38

There's a whole bunch of functions that access the cookie - we either refactor the functionality significantly or revert to using a cookie? Accessing localStorage obviously is not possible from PHP. Please advise :)

function _toolbar_is_collapsed() { // checks cookie, called from many places ...
function toolbar_preprocess_html(&$vars) { // attaches a class toolbar to the body?
function toolbar_toggle_page() { // toggles cookie
etc.