Well there's no API docs for features... yay... #1683194: missing api.php file.

But AFAICT hook_features_revert() doesn't need to return anything, and in fact, nothing is done with its return value: #1683196: API docs and context_features_revert() have incorrect return.

So our implementation needn't bother returning anything.

CommentFileSizeAuthor
#3 features-no-return-1683204.patch365 bytesAnonymous (not verified)

Comments

joachim’s picture

joachim commented
Status: Active » Postponed

Features can't make up its mind about this: #1683196: API docs and context_features_revert() have incorrect return.

joachim’s picture

joachim commented
Status: Postponed » Active
Issue tags: +Novice

Maintainer has confirmed that nothing should get returned.

Tagging as novice as it's an easy one for someone to make a patch for.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new features-no-return-1683204.patch365 bytes

Question... When you create a patch, and using the form of [description]-[issue-number]-[comment-number].patch, what is comment number? I'm leavin it off, but should mine have been 2 or 3? I'm guessing 2 since 3 doesn't exist, right?

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

I tend to use issue.comment.project.description.patch, which has the advantages that patches are listed together in a folder, and I can paste the issue number and then autocomplete in the command line. You'd use 3 as the comment id of the comment you're about to post. It's shown in grey to the left of the comment form. Of course, if two people post a comment at the same time then it doesn't work... The alternative is to just number them sequentially.

Thanks for the patch!

joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Issue #1683204 by bberl: Fixed hook_features_revert() returning useless value.

joachim’s picture

joachim commented
Version: 7.x-2.x-dev » 6.x-2.x-dev

Fixed on 6.x-2.x too.

Automatically closed -- issue fixed for 2 weeks with no activity.