Is it really necessary to include the puppet-aegir code in this repo?

It's in: aegir-up/blueprints/aegir/modules/aegir/

I don't mind, but it should be documented.

Comments

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Active » Postponed (maintainer needs more info)

Well, it should be in blueprints/aegir-dev/modules/aegir/, with a symlink from blueprints/aegir/modules. Since the aegir-up puppet module basically just calls stuff from the aegir module, we do still need it. However, for historical reasons, it was included as a git sub-tree, which also means we have a bunch of extra branches.

Except for the puppet modules specific to a given project (e.g., aegir-up, drush-vagrant), I'd like to clean this up by removing the modules themselves, along with their branches, and including them as submodules instead. However, my preference would be to simply list them in the drush-vagrant hook, and have them cloned as submodules in the build process.

Thoughts?

helmo’s picture

helmo commented

I was not aware these extra branches were a result of the puppet module. So removing them seems like a good idea.

A check in the drush-vagrant hook will make sure has all the required files.